feat: re-add pickle support for Pubkey, Hash, and Signature #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neriat
force-pushed
the
re-add-pickle-support
branch
from
ddb14ff to
93d4290
Compare
Pickle support was removed in v0.25.0 when upgrading to pyo3 0.23 due to breaking API changes in the old __reduce__ implementation. This commit restores pickle support using the __getnewargs__ protocol, which is simpler and more idiomatic for immutable byte-wrapper types. This approach is fully compatible with pyo3 0.23+ and avoids deprecated APIs like IntoPy and Python::acquire_gil(). Changes: - Add __getnewargs__ method to Pubkey, Hash, and Signature - Re-add pickle tests for all three types - All 35 existing tests pass The implementation leverages the immutable nature of these types, returning their byte representation directly to pickle for reconstruction via __new__.
neriat
force-pushed
the
re-add-pickle-support
branch
from
93d4290 to
dd8db6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickle support was removed in v0.25.0 when upgrading to pyo3 0.23 due to breaking API changes in the old
__reduce__implementation.This PR restores pickle support using the
__getnewargs__protocol, which is simpler and more idiomatic for immutable byte-wrapper types. This approach is fully compatible with pyo3 0.23+ and avoids deprecated APIs likeIntoPyandPython::acquire_gil().Changes
__getnewargs__method to Pubkey, Hash, and SignatureImplementation Details
The implementation leverages the immutable nature of these types (glorified byte wrappers), returning their byte representation directly to pickle for reconstruction via
__new__. This is much simpler than the old__reduce__approach and doesn't require any manual class lookup or deprecated pyo3 APIs.Testing
uv run pytest tests/test_pubkey.py::test_pickle tests/test_hash.py::test_pickle tests/test_signature.py::test_pickle -v # All tests PASSED