allow empty header values #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
commented
Nov 19, 2025
Comment on lines
-54
to
+55
| template <class T> size_t name_max(const std::unordered_map<std::string, T>& methods) { | ||
| template <class T> | ||
| size_t name_max(const std::unordered_map<std::string, T>& methods) { |
kevinkreiser
commented
Nov 19, 2025
Comment on lines
+464
to
465
| if ((field_end = partial_buffer.find(':')) == std::string::npos) | ||
| throw RESPONSE_400; |
Owner
Author
There was a problem hiding this comment.
ok so we still bail if you send headers with no : to separate name and value
kevinkreiser
commented
Nov 19, 2025
Comment on lines
+466
to
+468
| if ((value_begin = partial_buffer.find_first_not_of(' ', field_end + 1)) == | ||
| std::string::npos) | ||
| value_begin = partial_buffer.size(); |
Owner
Author
There was a problem hiding this comment.
but now if you dont send a value or if your value is all whitespace we detect that and set the value to empty string
kevinkreiser
commented
Nov 19, 2025
Comment on lines
-268
to
+291
| testable_http_server_t server(context, "ipc:///tmp/test_http_server", | ||
| "ipc:///tmp/test_http_proxy_upstream", "ipc:///tmp/test_http_results", | ||
| "ipc:///tmp/test_http_interrupt", false, | ||
| MAX_REQUEST_SIZE, -1, | ||
| testable_http_server_t server( | ||
| context, "ipc:///tmp/test_http_server", "ipc:///tmp/test_http_proxy_upstream", | ||
| "ipc:///tmp/test_http_results", "ipc:///tmp/test_http_interrupt", false, MAX_REQUEST_SIZE, -1, |
Owner
Author
There was a problem hiding this comment.
more linter blowback
kevinkreiser
commented
Nov 19, 2025
Comment on lines
+193
to
+203
| request_str = "GET /empty HTTP/1.1\r\nx-often-empty-header: \r\n\r\n"; | ||
| request = http_request_t::from_string(request_str.c_str(), request_str.size()); | ||
| auto empty = request.headers.find("x-often-empty-header"); | ||
| if (empty == request.headers.cend() || !empty->second.empty()) | ||
| throw std::runtime_error("Request parsing failed"); | ||
|
|
||
| request_str = "GET /empty HTTP/1.1\r\nx-often-empty-header:\r\n\r\n"; | ||
| request = http_request_t::from_string(request_str.c_str(), request_str.size()); | ||
| auto still_empty = request.headers.find("x-often-empty-header"); | ||
| if (still_empty == request.headers.cend() || !still_empty->second.empty()) | ||
| throw std::runtime_error("Request parsing failed"); |
Owner
Author
There was a problem hiding this comment.
we try with no value but a ton of whitespace and then again with literally nothing, then below we make sure that no colon still fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nilsnolde is making good progress on vector tile serving and noticed an issue when hooking it up to qgis. prime_server chokes on the requests. he did all the hard work of debugging it to the section of code that parses header names and values. basic gist is, prime_server wasnt allowing empty values. i guess i didnt read the rfc all that carefully.. anyway this pr adds tests for and fixes that.