Skip to content

Refactor shared animation logic into useFortuneAnimation hook#134

Merged
kevlatus merged 1 commit into
mainfrom
refactor-shared-animation-logic-10603008920263147183
Jan 9, 2026
Merged

Refactor shared animation logic into useFortuneAnimation hook#134
kevlatus merged 1 commit into
mainfrom
refactor-shared-animation-logic-10603008920263147183

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

Extracted duplicated animation logic from FortuneBar and FortuneWheel into a new shared hook useFortuneAnimation in lib/src/core/animations.dart.
This hook manages:

  • AnimationController creation
  • CurvedAnimation creation
  • Logic to run animation on start (if enabled)
  • Logic to listen to selection stream and run animation
  • Updating selectedIndex state

Updated FortuneBar and FortuneWheel to use this hook and access the controller, animation, and selectedIndex from the returned FortuneAnimation object.
Verified visually that logic is preserved and files are updated correctly. Tests could not be run due to missing Flutter environment, but the refactoring is a straightforward extraction of existing logic.


PR created automatically by Jules for task 10603008920263147183 started by @kevlatus

Extracted the common animation logic from FortuneBar and FortuneWheel into a reusable hook useFortuneAnimation located in lib/src/core/animations.dart. This hook handles the animation controller, curved animation, and selection stream listening. This reduces duplication and improves maintainability.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@kevlatus kevlatus marked this pull request as ready for review January 9, 2026 06:33
@kevlatus kevlatus merged commit be26bc7 into main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant