Redesign FortuneBar indicator to be static in size#142
Conversation
- Changed FortuneBar to use a fixed `unitWidth` for the indicator size instead of resizing it dynamically based on the item passing under it. - Wrapped indicator child in `Center` to allow it to choose its size or fill the fixed slot. - Removed `_getIndicatorWidth`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the issue where the indicator in
FortuneBarwould weirdly resize as items with different weights (widths) passed under it.The solution is to use a fixed width for the indicator container, equal to the width of a standard item (weight 1).
The indicator is now centered within this fixed slot. This ensures a stable and visually appealing indicator, compatible with varying item sizes (acting like a fixed selection window).
PR created automatically by Jules for task 6319467888006205686 started by @kevlatus