Skip to content

Port DDCaloDigi to Gaudi #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 24, 2025
Merged

Conversation

kkostova16
Copy link

BEGINRELEASENOTES

  • Port DDCaloDigi from MarlinPandora to Gaudi

ENDRELEASENOTES

@andresailer andresailer force-pushed the portDDCaloDigiPR branch 2 times, most recently from 532071d to 25d71f3 Compare March 19, 2025 12:44
@andresailer andresailer force-pushed the portDDCaloDigiPR branch 2 times, most recently from d446ae0 to 22ce45e Compare March 19, 2025 13:38
@andresailer
Copy link
Contributor

Hi @jmcarcell

The builds against the release fail because I use StaticWeightedHistogram. Is this something you already faced? Things didn't compile because of a missing registerCallback for histogram creation, and I changed all histograms to Static as well.

@andresailer
Copy link
Contributor

Hi @jmcarcell

The builds against the release fail because I use StaticWeightedHistogram. Is this something you already faced? Things didn't compile because of a missing registerCallback for histogram creation, and I changed all histograms to Static as well.

Do something like here https://github.com/key4hep/k4RecTracker/blob/db31575182a8df88320a48cece516c2263719a1c/Tracking/components/PlotTrackHitResiduals.cpp#L21C1-L30C7

to make it compile with the release as well.

@andresailer andresailer force-pushed the portDDCaloDigiPR branch 2 times, most recently from ff81e09 to fca2e88 Compare March 20, 2025 16:35
Co-authored-by: Mateusz Jakub Fila <[email protected]>
@jmcarcell
Copy link
Member

I think this is ready to merge @andresailer, I'll let you decide when. Let's ignore the formatting for now, as I have been updating to the common .clang-format and it will be easier after the PRs are merged.

@andresailer
Copy link
Contributor

Thanks!
I will merge this now then.

@andresailer andresailer merged commit 46849a6 into key4hep:main Mar 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants