Port DDCaloDigi to Gaudi #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
reviewed
Sep 6, 2024
andresailer
reviewed
Sep 10, 2024
| //std::string initString = m_geoSvc->constantAsString(m_encodingStringVariable.value()); | ||
|
|
||
| //FIXME: take this from the metadata | ||
| std::string initString = "system:5,side:2,module:8,stave:4,layer:9,submodule:4,x:32:-16,y:-16"; |
There was a problem hiding this comment.
FIXME: waiting for changes in metadata svc to pick this up
There was a problem hiding this comment.
Sorry to ping you, can you tell me how to use the metadata svc here? Or point me to the documentation.
There was a problem hiding this comment.
There was a problem hiding this comment.
Not sure whether it is documented yet, but essentially, you do what is in that example yes.
#include "k4FWCore/MetadataUtils.h"
// in initialize or finalize
k4FWCore::putParameter("the-key", "the-value"); // for all supported types
// everywhere
const auto maybeParam = k4FWCore::getParameter<std::string>("the-key"); // for all supported types
const auto value = maybeParam.value();
added 2 commits
September 10, 2024 15:09
… since not needed. Clean up some old comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES