-
Notifications
You must be signed in to change notification settings - Fork 6
Port DDCaloDigi to Gaudi #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cab5ff7
to
c8d1493
Compare
… since not needed. Clean up some old comments
532071d
to
25d71f3
Compare
d446ae0
to
22ce45e
Compare
Hi @jmcarcell The builds against the release fail because I use StaticWeightedHistogram. Is this something you already faced? Things didn't compile because of a missing registerCallback for histogram creation, and I changed all histograms to Static as well. |
Previously this was a pair of id0 and id1, but now we just have a single 64bit cellID to use, so we do not need a variable here
This is a left over from the strip-splitting treatment, IIRC
22ce45e
to
081c63d
Compare
Do something like here https://github.com/key4hep/k4RecTracker/blob/db31575182a8df88320a48cece516c2263719a1c/Tracking/components/PlotTrackHitResiduals.cpp#L21C1-L30C7 to make it compile with the release as well. |
b20f685
to
8cee6f9
Compare
ff81e09
to
fca2e88
Compare
Co-authored-by: Mateusz Jakub Fila <[email protected]>
fca2e88
to
a4f1a83
Compare
I think this is ready to merge @andresailer, I'll let you decide when. Let's ignore the formatting for now, as I have been updating to the common |
Thanks! |
BEGINRELEASENOTES
ENDRELEASENOTES