-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the MDI Version of the ILD FCCee Models to MDI_o1_v01 #428
base: main
Are you sure you want to change the base?
Conversation
fyi @danieljeans |
checks fail because the stl files for |
Hi @Victor-Schwan, It seems that the release currently does not provide the CAD files necessary to build the fancy beampipe, which is causing the tests for ILD to fail. To address this, I would suggest one of the following options:
Let me know your thoughts, and I'd be happy to discuss further. |
Or we enable the cmake option |
key4hep/key4hep-actions#9 would make it possible to easily pass that additional option for the CI. |
I am in favor of adapting the tests such that the cmake option |
fd2db22
to
3a2b44b
Compare
Hi @Victor-Schwan, I ran the test for ILD, which is currently failing. In addition to the missing files, I noticed another issue: when initializing the geometry, Geant4 detects an error in the beampipe CAD. Specifically, a facet is incorrectly oriented at z = +/-1111 mm, triggering the following warning message:
Although this is only a warning, the test fails due to the following property in
I think @aciarma is investigating the issue. In the meantime, could we consider modifying the ctest configuration to avoid failing on this Geant4 warning? Let me know your thoughts :) |
Hello, yes I am investigating the problem of the wrongly oriented facets, but it seems like there is not much to do when exporting the STL file from CAD. This does not seem to have an impact on the tracking of particles, but if we find a solution or a fix I will update the models |
0f95aac
to
e435742
Compare
e435742
to
cf5cf40
Compare
On @BrieucF 's recommendation, the default MDI version of the ILD FCCee models is changed to
MDI_o1_v01
.BEGINRELEASENOTES
MDI_o1_v01
ENDRELEASENOTES