Adding support for a tool that will generate a json file of all of our Key_ macros. #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a file listing all possible keycodes - Extracted key definition constants to `key_def_constants.h` - Moved base key definitions to `key_defs/base.h` - Moved legacy key definitions to `key_defs/legacy.h` - Updated `key_defs.h` to include the new headers and remove now redundant definitions - Ensured compatibility and organization of key definitions across the codebase
- Added `extract-keys.sh` to extract argument-taking and non-argument-taking macros from key definitions. - Added `generate-macro-printer.sh` to generate a C++ program for printing macro values.
files ontaining only key definitions to make introspection and codegen around lists of keys more straightforward
- Removed extra spaces for consistency in `key_defs/legacy.h`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is...nowhere near ready. The individual parts almost work for key definitions inside the core of Kaleidoscope, but don't handle plugins yet.
Right now, the way to run this tooling is:
extract-keys.sh is going to need to be a lot smarter to handle plugins and the path of least resistance may involve refactoring some plugins to make their key macros easier to extract.