-
Notifications
You must be signed in to change notification settings - Fork 280
Add EEPROM and focus support to ColormapOverlay #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EvyBongers
wants to merge
19
commits into
keyboardio:master
Choose a base branch
from
EvyBongers:feat/ColormapOverlay/Focus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
747dcb3
Add TODOs for implemending EEPROM and focus support
EvyBongers 7d250a8
Implement focus reading colormap overlays
EvyBongers 3da5d29
Read color overlays from focus
EvyBongers 1f860be
Add missing imports
EvyBongers ae4ee9c
Fix variable references
EvyBongers ff93006
Merge remote-tracking branch 'upstream/master' into feat/ColormapOver…
EvyBongers 42d0777
Fix type error
EvyBongers 90692a6
Add missing include in example sketch
EvyBongers ea611d0
Add sketch files to example
EvyBongers 22d8790
Update TODO with preliminary findings
EvyBongers 50fbd80
Some initial work for EEPROM support
EvyBongers 3c3218c
Overlays should be static to work with EEPROM
EvyBongers 11a8e54
Merge branch 'master' into feat/ColormapOverlay/Focus
EvyBongers ad4b5bc
Be consistent in how int vars are incremented
EvyBongers 9505c90
When EEPROM has invalid data, don't use it
EvyBongers 3151f4a
Remember to increment the overlay counter
EvyBongers ad05608
Stop processing Focus data once max overlays is hit
EvyBongers 7000299
Ensure sketches don't exceed max_overlays_
EvyBongers 5d7583e
Have ColormapOverlay force active led mode to refresh
EvyBongers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
plugins/Kaleidoscope-Colormap-Overlay/examples/Colormap-Overlay/sketch.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "cpu": { | ||
| "fqbn": "keyboardio:gd32:keyboardio_model_100", | ||
| "port": "" | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
plugins/Kaleidoscope-Colormap-Overlay/examples/Colormap-Overlay/sketch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| default_fqbn: keyboardio:gd32:keyboardio_model_100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.