Add direction-aware debouncing for Preonic rotary encoders#1522
Merged
Conversation
PROBLEM: Preonic encoders have 12 physical detents per rotation but generate 24 electrical events, causing double the expected key events. Additionally, encoder bounce and rapid direction changes can cause spurious events in the wrong direction. SOLUTION: Implement direction-aware decimation in encoderEventCallback(): - Track direction for each encoder independently - Reset counter on direction changes to prevent wrong-direction events - Only process every Nth event within the same direction (N=2 for Preonic) CONFIGURATION: ENCODER_STEPS_PER_DETENT constant allows adjustment for different encoder types. RESULT: Clean 1:1 mapping between physical detents and key events, with elimination of bounce-induced wrong-direction events. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
This fixes #1469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes encoder sensitivity issues on the Preonic by implementing direction-aware debouncing that eliminates double events and wrong-direction spurious events.
Problem
Root Cause
Solution: Direction-Aware Decimation
Implement smart filtering in
encoderEventCallback():Technical Details
Results
Test Plan
🤖 Generated with Claude Code