fix: fix spacebar in studio in MIT layout #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua T <[email protected]>
replicaJunction
force-pushed
the
spacebar-fix
branch
from
27f6266 to
9ae2817
Compare
Merged
Contributor
Author
|
I developed this and #3 in parallel, but chose to split them out for cleanliness. They are compatible, and I have merged them locally with no merge conflicts. If you would prefer I combine them into one PR instead, let me know and I'd be happy to do so. |
Member
|
That is correct. Thanks for the fix. The design is such that with the default map simply swapping the keys results in right being space and left being backspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the behavior of the 2u spacebar when using the MIT layout in ZMK Studio.
I was operating under the assumption that it shared its mapping with the left 1u key. That was incorrect; it shares its behavior with the right key instead.
This time, I took the time to swap my switches and validate the behavior! I also have a confirmation from another user on Discord that this behavior is correct.