Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions to v4 and selenium/arquillian dependencies for chrome 134 #663

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Mar 10, 2025

Closes #662

There is a failure in extension nightly due to keycloak/keycloak#37656. That one is not related to the quickstarts (initially). So I'm sending the PR for just the upgrade of the actions.

@rmartinc rmartinc marked this pull request as draft March 11, 2025 10:51
@rmartinc
Copy link
Contributor Author

Converted to draft to wait PR keycloak/keycloak#37656. When merged we can also change the hibernate.xml to use the new property and not the deprecated one.

@rmartinc
Copy link
Contributor Author

Updated the PR with changes for chrome 134. It is the same than in keycloak. We need to use newer versions or arquillian/selenium and more waits. If everything goes OK I'll move the PR out of draft.

@rmartinc rmartinc marked this pull request as ready for review March 13, 2025 16:25
@rmartinc rmartinc changed the title Upgrade versions or GitHub actions to v4 Upgrade GitHub Actions to v4 and selenium/arquillian dependencies for chrome 134 Mar 13, 2025
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks for the updates!

@mposolda mposolda merged commit 9455faf into keycloak:main Mar 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing for keycloak-quickstarts
2 participants