Skip to content

Update webhooks to not follow redirects #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezekg merged 1 commit into from
Jul 23, 2026
Merged

Update webhooks to not follow redirects #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/workers/webhook_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,14 @@ def perform(account_id, event_id, endpoint_id, event_data)
end

Keygen.logger.info "[webhook_worker] Delivered webhook event: type=#{event_type.event} account=#{account.id} event=#{event.id} endpoint=#{endpoint.id} url=#{endpoint.url} code=#{res.code}"
rescue HTTParty::RedirectionTooDeep => e
Keygen.logger.warn "[webhook_worker] Failed webhook event: type=#{event_type.event} account=#{account.id} event=#{event.id} endpoint=#{endpoint.id} url=#{endpoint.url} code=REDIRECT_ERROR"

event.update!(
last_response_code: e.response.code,
last_response_body: 'REDIRECT_ERROR',
status: 'FAILED',
)
rescue OpenSSL::SSL::SSLError # Endpoint's SSL certificate is not showing as valid
Keygen.logger.warn "[webhook_worker] Failed webhook event: type=#{event_type.event} account=#{account.id} event=#{event.id} endpoint=#{endpoint.id} url=#{endpoint.url} code=SSL_ERROR"

Expand Down Expand Up @@ -251,5 +259,7 @@ def backtrace = nil

class Request
include HTTParty

no_follow true
end
end
Loading