Update E-121 to change endpoint name #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Enhancement keylime#121 to use /verify/evidency instead of just /verify since /verify/identity already exists. Also change to use "valid" return parameter instead of "success" to matter match other Keylime APIs Signed-off-by: Michael Peters <[email protected]>
ansasaki
approved these changes
Jun 10, 2025
| @@ -150,7 +127,7 @@ response as we can for the failure(s). | |||
| The API will return a response like the following: | |||
|
|
|||
| { | |||
| "success": 0, | |||
| "valid": 0, | |||
There was a problem hiding this comment.
Do we expect this to receive values other than 0 or 1 in future?
If not, I would suggest to change this to be an actual boolean and not an integer.
If yes, then, I would change the field name to something like result because valid receiving a range of possible values is confusing (at least to me).
There was a problem hiding this comment.
I agree that they should be booleans, but for the moment I was making it more consistent with other APIs like /verify/identity and /mbpolicies/. If we do change them they should all be changed together, but probably in another enhancement/change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Enhancement #121 to use /verify/evidency instead of just /verify since /verify/identity already exists.
Also change to use "valid" return parameter instead of "success" to matter match other Keylime APIs