Skip to content

Add UEFI log handler, use it to send UEFI count #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarroutbi
Copy link
Contributor

Resolves: #1020

@keylime-bot keylime-bot added bug Something isn't working Push Model Issues that are specific to the Keylime Push Model new binary labels Jun 9, 2025
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch 18 times, most recently from 30f8b65 to c66ad32 Compare June 9, 2025 16:53
@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from c66ad32 to 502dc4f Compare June 9, 2025 17:00
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 43 lines in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (07167a0) to head (52128d5).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/uefi/uefi_log_handler.rs 77.77% 32 Missing ⚠️
keylime-push-model-agent/src/struct_filler.rs 53.33% 7 Missing ⚠️
keylime/src/config/push_model_config.rs 69.23% 4 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 69.98% <75.00%> (+0.06%) ⬆️
upstream-unit-tests 69.98% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/keylime_error.rs 62.96% <ø> (ø)
keylime/src/structures/capabilities_negotiation.rs 71.42% <ø> (ø)
keylime/src/config/push_model_config.rs 91.11% <69.23%> (-4.30%) ⬇️
keylime-push-model-agent/src/struct_filler.rs 83.50% <53.33%> (-5.52%) ⬇️
keylime/src/uefi/uefi_log_handler.rs 77.77% <77.77%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from 502dc4f to c69a77b Compare June 9, 2025 18:11
@sarroutbi sarroutbi marked this pull request as ready for review June 9, 2025 18:11
@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi sarroutbi force-pushed the 202506091610-add-uefi-log-handler branch from c69a77b to 52128d5 Compare June 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Push Model Issues that are specific to the Keylime Push Model new binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Model agent is not sending amout of UEFI logs amount appropriately
4 participants