docs: add documentation on FQDN hostnames #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @ansasaki |
36 tasks
Contributor
|
/packit retest-failed |
Contributor
Author
|
Can I get a review for this docs change? Filed #1161 for the bot crash, in case that somehow makes this not be visible on someone radar... |
sergio-correia
approved these changes
Dec 9, 2025
Contributor
|
Would you mind rebasing the commit on top of the current tree? |
Last year, support for FQDN hostnames instead of only IP addresses were added. In that PR, no documentation changes were made. Variable names are still for compatibility reasons ending with _ip, which might be confusing. This commit adds relevant documentation what the fields accept in the config file inline help. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/add-fqdn-docs
branch
from
2264d7e to
8c7a198
Compare
Contributor
Author
Done. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year, support for FQDN hostnames instead of only IP addresses were added in #866. In that PR, no documentation changes were made. Variable names are still for compatibility reasons ending with
_ip, which might be confusing. This commit adds relevant documentation what the fields accept in the config file inline help.