Ensure U-Boot is cleaned when OpenSBI is cleaned to update Security Monitor #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: I am using Keystone on a SiFive HiFive Unmatched Rev B board and frequently modify the Security Monitor (SM) for testing.
Problem: Currently, running the following command does not update the final SD card image as expected:
make BUILDROOT_TARGET=keystone-sm-dirclean && makeWhile
keystone-sm-dircleancorrectly triggersopensbi-dirclean, the U-Boot artifacts are not rebuilt. Consequently, changes to the Security Monitor are not reflected in the final image on devices where U-Boot embeds or depends on the OpenSBI binary.Solution: This PR adds a dependency ensuring that
uboot-dircleanis triggered wheneveropensbi-dircleanruns, provided U-Boot is enabled. This ensures all boot components are properly rebuilt and the latest SM changes are propagated to the generated SD card image.