feat: add startup telemetry status logs#9822
feat: add startup telemetry status logs#9822abhijnyan-codes wants to merge 3 commits intokeystonejs:mainfrom
Conversation
| process.env.KEYSTONE_TELEMETRY_DISABLED === '1' // don't run if the user has disabled it | ||
| ) { | ||
| if (ci.isCI) { | ||
| console.log(`Keystone Telemetry is ${r`disabled`} (running in CI)`) |
There was a problem hiding this comment.
please use the log function used by the rest of file, not console.log
please change the prefix, s/Keystone Telemetry is/telemetry is
There was a problem hiding this comment.
Thanks for the feedback! I noticed the existing log() function only outputs when KEYSTONE_TELEMETRY_DEBUG=1, which would hide these status messages from regular users. Should I use log() anyway, or is there another logging utility I should use instead?
There was a problem hiding this comment.
ah, true, sorry, I think we want the logging approach used by the rest of the codebase for this - not the log from this file
|
@abhijnyan-codes at the same time as this, did you want to add support to opt-out if the user has |
|
Added DO_NOT_TRACK=1 support as well. |
|
Thanks @abhijnyan-codes, if you can add a changeset, I will resolve the last remaining tidbits |
|
Added the changeset! |
Closes #9299
Added log messages to runTelemetry() to inform users of telemetry status at startup: