fix: add error logging to access control catch block#9824
Open
gugli4ifenix-design wants to merge 1 commit intokeystonejs:mainfrom
Open
fix: add error logging to access control catch block#9824gugli4ifenix-design wants to merge 1 commit intokeystonejs:mainfrom
gugli4ifenix-design wants to merge 1 commit intokeystonejs:mainfrom
Conversation
Silent catch in checkUniqueItemExists swallows all DB errors, making access control issues impossible to debug in development. This adds a console.warn in non-production environments when findOne fails, while preserving the existing deny-on-error behavior. Found during a static analysis sweep of popular open source projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkUniqueItemExistsinaccess-control.tshas an empty catch block (line 431) that silently swallows all errors fromfindOne:If
findOnefails for any reason (DB connection error, misconfiguration, schema mismatch), the error is invisible — making access control issues extremely hard to debug in development.Fix
Add
console.warnin non-production environments:Found during a static analysis sweep of 97 popular open source projects.