chore: update and pin all dependencies - #5
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThe PR systematically pins dependency versions across the monorepo by replacing flexible version ranges with fixed versions. It updates development tools (prettier, turbo) at the root level, upgrades runtime and dev dependencies in backend and frontend packages, updates Go from 1.24.0 to 1.25.0, and removes the default Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env.example:
- Around line 169-170: Update the NODE_ENV comment to avoid implying frameworks
set it automatically: state that the backend determines NODE_ENV via its config
parsing (so do not override it in local .env), and add a clear warning not to
set NODE_ENV=production when running development with make dev; reference the
NODE_ENV variable and the local .env usage so maintainers understand what to
avoid.
In `@packages/dashboard/package.json`:
- Around line 36-39: Update the React stack to the recommended version by
changing the "react" and "react-dom" dependencies in package.json from "18.3.1"
to the React 19 release (e.g., "19.x.x"); ensure compatibility with "next"
(Next.js 15) by also verifying any peerDependencies or related packages like
"next-themes" still work with React 19 and run the project's install and test
scripts to catch any breaking changes before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cfe46af6-fdf9-4dcd-b7d6-1ec00406f65d
⛔ Files ignored due to path filters (3)
packages/cli/go.sumis excluded by!**/*.sumpackages/crypto/go.sumis excluded by!**/*.sumpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
.env.examplepackage.jsonpackages/backend/package.jsonpackages/cli/go.modpackages/crypto/go.modpackages/dashboard/package.jsonpackages/docs/package.jsonpackages/mcp/package.json
| "next": "15.5.14", | ||
| "next-themes": "0.4.6", | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For Next.js 15.5.x App Router projects, what is the official support/recommendation status of React 18.3.x vs React 19.x?
💡 Result:
For Next.js 15.5.x App Router projects, React 19.x is the official recommendation and stable support, while React 18.3.x is supported via peer dependency compatibility (e.g., "^18.2.0 || ^19.0.0") but not the primary recommendation for App Router, which aligns with React 19 features. Upgrade instructions emphasize installing react@latest (React 19.x).
Citations:
- 1: Can React 18 be used with Next.js version 15? vercel/next.js#72795
- 2: https://nextjs.org/blog/next-15-1
- 3: https://nextjs.org/docs/app/building-your-application/upgrading/version-15
- 4: https://nextjs.org/blog/next-15
- 5: https://nextjs.org/docs/app/guides/upgrading/version-15
- 6: https://www.npmjs.com/package/next/v/15.0.2
Upgrade React to v19 for optimal Next.js 15 App Router support.
React 19 is the official recommendation for Next.js 15 App Router projects. While React 18.3.1 is supported via peer dependency compatibility, Next.js 15 features align with React 19 and it is the primary supported version moving forward. Consider upgrading to React 19 to follow the recommended stack.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/dashboard/package.json` around lines 36 - 39, Update the React stack
to the recommended version by changing the "react" and "react-dom" dependencies
in package.json from "18.3.1" to the React 19 release (e.g., "19.x.x"); ensure
compatibility with "next" (Next.js 15) by also verifying any peerDependencies or
related packages like "next-themes" still work with React 19 and run the
project's install and test scripts to catch any breaking changes before merging.
|
Re: React 19 upgrade — Acknowledged, but this is a breaking major version change (new hook semantics, removed APIs, etc.) that doesn't belong in a dependency pinning PR. Will handle in a dedicated PR with proper testing. Re: NODE_ENV comment — Fixed in 34eb6da. CI fixes in 34eb6da:
|
Update all TS and Go dependencies to latest within semver ranges and pin exact versions (remove ^ and ~ prefixes) to mitigate supply chain attacks. Also removes NODE_ENV from .env/.env.example to fix Next.js warning when running `make dev`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ci-crypto: read Go version from go.mod instead of hardcoding 1.24 - ci-cli: upgrade golangci-lint-action to v7 with golangci-lint v2.11.4 (v1.64.8 was built with Go 1.24, incompatible with go.mod targeting 1.25) - golangci.yml: migrate config to v2 format (linters-settings → linters.settings) - package.json: add pnpm override for serialize-javascript >= 7.0.3 (fixes GHSA-5c6j-r48x-rmvq RCE via Docusaurus transitive dep) - .env.example: clarify NODE_ENV comment per review feedback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
34eb6da to
a8627ef
Compare
Move issues.exclude-rules to linters.exclusions.rules per golangci-lint v2 schema requirements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add errcheck exclusions for color.Printf, io.ReadCloser.Close, os.File.Close (standard Go patterns, not real bugs) - Fix staticcheck QF1001 in set.go: apply De Morgan's law for readability Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
^and~prefixes) to mitigate supply chain attacksNODE_ENV=productionfrom.envand.env.exampleto fix Next.js warning duringmake devWhat changed
Test plan
pnpm buildpasses (all 4 TS packages)pnpm testpasses (923 backend + 790 dashboard + MCP tests)go buildpasses (CLI + crypto)go testpasses (735 CLI + 133 crypto)make dev🤖 Generated with Claude Code
Summary by CodeRabbit
Chores