feat: option to fail eagerly with Error::NoHosts #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 86.39% 84.89% -1.51%
==========================================
Files 34 34
Lines 4764 4773 +9
==========================================
- Hits 4116 4052 -64
- Misses 648 721 +73 ☔ View full report in Codecov by Sentry. |
This reverses the default behavior and give us chance to not fail with Error::NoHosts. This commit also refactors test_readonly a bit with help from above. Closes #34.
kezhuw
force-pushed
the
option_fail_eaglerly_with_nohosts
branch
from
b491b2c to
beb1684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34.