Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enrich logging message for ConnectionLoss #41

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

kezhuw
Copy link
Owner

@kezhuw kezhuw commented Mar 31, 2024

Error::ConnectionLoss itself carries no cause, thus less useful.

`Error::ConnectionLoss` itself carries no cause, thus less useful.
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.93%. Comparing base (1d49afa) to head (d54a19d).

Files Patch % Lines
src/session/mod.rs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   85.10%   84.93%   -0.17%     
==========================================
  Files          34       34              
  Lines        4799     4800       +1     
==========================================
- Hits         4084     4077       -7     
- Misses        715      723       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kezhuw kezhuw merged commit 5b8ba3b into master Mar 31, 2024
15 checks passed
@kezhuw kezhuw deleted the connectionloss-logging branch March 31, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant