refactor: merge connecting and serving depots into one #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
merge-connecting-serving-depots
branch
from
b6e70f9 to
7953dca
Compare
Those two are there from initial day to keep `pending_authes` cross reconnection. But turns out, it is verbose and confusing. Treating `pending_authes` specially is enough for us to go. By merging them into one, we could share partial state among connection states, e.g. `xid`.
kezhuw
force-pushed
the
merge-connecting-serving-depots
branch
from
7953dca to
0c72c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two are there from initial day to keep
pending_authescrossreconnection. But turns out, it is verbose and confusing. Treating
pending_authesspecially is enough for us to go.By merging them into one, we could share partial state among connection
states, e.g.
xid.