Changes for UTF8 character representation within string literals #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added UTF8 Unit in mosmllib
- Changed Lexer.lex to check UTF8 encodings in string literals and allow
full ISO/IEC 1064 UCS encodings to be used in numerical escapes:
\U+XXXXXX
as well as
\uXXXX
as specified in the Standard ML Definition.
UTF8 checking within character strings is non-standard compiler behavior
and the switch Meta.utf8 is provided to switch this checking on. Thinking
about it now, the extended syntax for numeric character literals should
probably be conditional on that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UTF8 Unit in mosmllib
Modified PP.sml to correctly format multi-octed UTF8 strings (it needs to parse the UTF8 representations to do this)
Changed Lexer.lex to check UTF8 encodings in string literals and allow full ISO/IEC 1064 UCS encodings to be used in numerical escapes:
\U+XXXXXX
as well as
\uXXXX
as specified in the Standard ML Definition.
UTF8 checking within character strings is non-standard compiler behavior and the switch Meta.utf8 is provided to switch this checking on. Thinking about it now, the extended syntax for numeric character literals should probably be conditional on that too.
Some of the logic came from the HOL Theorem prover, but they are doing it differently now, see: src/portableML/UTF8.sml in https://github.com/HOL-Theorem-Prover/HOL