-
Notifications
You must be signed in to change notification settings - Fork 25
Nominate chandler-solo as maintainer #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc2660b to
5818011
Compare
Signed-off-by: omar <omar.hammami@solo.io>
5818011 to
0f86792
Compare
Signed-off-by: omar <omar.hammami@solo.io>
41a26a3 to
1a1c732
Compare
org.yaml
Outdated
| controller-maintainers: | ||
| description: Maintainers of the kgateway repo | ||
| maintainers: | ||
| - chandler-solo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to go below, under members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
I agree to all of the responsibilities and requirements of being a kgateway-dev maintainer. |
|
+1 congrats chandler! |
|
+1 🎉 |
|
+1 thanks for all the great work @chandler-solo adding the do-not-merge to keep this open for the ~1 week waiting period |
Maintainer Nomination
Nominee's GitHub user ID: chandler-solo
Summary of contributions:
Many contributions including helm chart refactoring, testing/ dev ux improvments, GatewayParameters API, and more.
PRs: https://github.com/kgateway-dev/kgateway/pulls?q=is%3Apr+author%3Achandler-solo+is%3Aclosed
Reviews: https://github.com/kgateway-dev/kgateway/pulls?q=is%3Apr+reviewed-by%3Achandler-solo+
Requirements:
orgs.kgateway-dev.teams.<team>.members) in org.yaml (maintaining alphabetical order)I agree to all of the responsibilities and requirements of being a kgateway-dev maintainer.