ci,go.*: Remove the gen-crd-api-reference-docs tool#10561
Closed
timflannagan wants to merge 1 commit intokgateway-dev:mainfrom
Closed
ci,go.*: Remove the gen-crd-api-reference-docs tool#10561timflannagan wants to merge 1 commit intokgateway-dev:mainfrom
timflannagan wants to merge 1 commit intokgateway-dev:mainfrom
Conversation
timflannagan
force-pushed
the
chore/remove-unnused-tool
branch
from
6376364 to
b9a5889
Compare
timflannagan
changed the title
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
chore/remove-unnused-tool
branch
from
b9a5889 to
d076db9
Compare
jenshu
reviewed
Jan 31, 2025
| sigs.k8s.io/yaml v1.4.0 | ||
| ) | ||
|
|
||
| require ( |
Contributor
There was a problem hiding this comment.
just curious why did these get broken out into a new require block?
Member
Author
There was a problem hiding this comment.
I'm on my phone, but it looks like I messed up with the merge conflicts when updating the branch 😢 .
/hold
Contributor
|
we actually may want to swap |
Member
Author
|
Closing until decision on #10568 is made. |
stevenctl
pushed a commit
to stevenctl/gloo
that referenced
this pull request
Feb 17, 2025
…gateway-dev#10561) (kgateway-dev#10567) Signed-off-by: Shashank Ram <shashank.ram@solo.io>
jbohanon
pushed a commit
to jbohanon/gloo
that referenced
this pull request
Mar 18, 2025
…#10561) Signed-off-by: Shashank Ram <shashank.ram@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unused github.com/ahmetb/gen-crd-api-reference-docs tool. We use the fybrik.io/crdoc tool right now.
Checklist: