-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Inference Extension Plugin and Deployer #10684
Draft
danehans
wants to merge
1
commit into
kgateway-dev:main
Choose a base branch
from
danehans:issue_10411_epp_plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: To pass CI, this PR includes a few identical commits as #10676 for go mod bump, code generations, etc. |
bd4d69b
to
b981485
Compare
yuval-k
reviewed
Feb 24, 2025
internal/kgateway/extensions2/plugins/inferenceextension/endpointpicker/plugin.go
Outdated
Show resolved
Hide resolved
out.CircuitBreakers = &envoy_config_cluster_v3.CircuitBreakers{ | ||
Thresholds: []*envoy_config_cluster_v3.CircuitBreakers_Thresholds{ | ||
{ | ||
MaxConnections: wrapperspb.UInt32(40000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is 40000 coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal/kgateway/extensions2/plugins/inferenceextension/endpointpicker/plugin.go
Outdated
Show resolved
Hide resolved
internal/kgateway/extensions2/plugins/inferenceextension/endpointpicker/plugin.go
Show resolved
Hide resolved
3539224
to
215d19c
Compare
This was referenced Feb 25, 2025
215d19c
to
9e3f6e3
Compare
eda00c9
to
c5c1063
Compare
e2b80f9
to
e69c752
Compare
Signed-off-by: Daneyon Hansen <[email protected]>
e69c752
to
c01ceec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds initial support for an inference extension endpoint picker deployer and plugin.
Plugin:
Deployer:
GatewayConfig
type since refactoring this type would further increase the size of this PR.API changes
N/A
Code changes
Plugin:
Deployer:
CI changes
N/A
Docs changes
Godocs added throughout. User docs will be added in a future PR.
Context
Supports #10411
Interesting decisions
Plugin:
Deployer:
Testing steps
Unit tests were added. e2e tests are still required and not included here due to the size of the PR.
Notes for reviewers
Checklist: