agentgateway: Add JWT, Basic authentication, and API Key authentication #12822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
github-actions
bot
added
do-not-merge/description-invalid
kind/feature
dmitri-d
reviewed
Nov 4, 2025
| // backendRef references the remote JWKS server to reach. | ||
| // | ||
| // Supported types: Service and Backend. | ||
| BackendRef gwv1.BackendObjectReference `json:"backendRef"` |
There was a problem hiding this comment.
we probably want to have keyset ttl configurable?
dmitri-d
reviewed
Nov 4, 2025
| Audiences []string `json:"audiences,omitempty"` | ||
| // jwks defines the JSON Web Key Set used to validate the signature of the JWT. | ||
| JWKS AgentJWKS `json:"jwks"` | ||
| } |
There was a problem hiding this comment.
this skips things like token source (header vs query), claim mapping config, and whether a token should be passed on to the next auth filter.
dmitri-d
reviewed
Nov 5, 2025
| } | ||
| } | ||
| for _, pp := range jwt.Providers { | ||
| jp := &api.TrafficPolicySpec_JWTProvider{ |
There was a problem hiding this comment.
jp is not being added to the list of providers in the policy, but rather discarded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #12378
For #12786
Change Type
/kind feature
Changelog
Additional Notes