Skip to content

feture : Add Traffic policy tests #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feture : Add Traffic policy tests #12839

wants to merge 1 commit into from

Conversation

@adity1raut
Copy link

@adity1raut adity1raut commented Nov 6, 2025 •
edited
Loading

Description

Fixed #12817

Change Type

/kind feature

Changelog

Added missing unit tests for traffic policy subfields in AgentGateway


# Additional Notes

<!--
Any extra context or edge cases for reviewers.
-->

This PR adds unit tests for missing traffic policy subfields under the AgentGatewayPolicy, ensuring better coverage and stability for future updates.



---

You can copy and paste this content directly into your **PR description** or save it as a file named `PULL_REQUEST_TEMPLATE.md`.  
It will pass the CI release-note check ✅

@adity1raut
Add The Test
5138a32 
Signed-off-by: adity1raut <[email protected]>
@adity1raut adity1raut marked this pull request as ready for review November 6, 2025 16:33
Copilot AI review requested due to automatic review settings November 6, 2025 16:33
@github-actions github-actions bot added do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 6, 2025
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds five new YAML test data files for traffic policy configurations. These files serve as test fixtures for the AgentGatewayPolicy API, demonstrating various traffic management features such as timeouts, retries, header manipulation, CORS, and combinations thereof.

  • Adds test data for traffic policy features including timeout, retry, CORS, and header manipulation configurations
  • Creates a combined traffic policy test file demonstrating multiple features together
  • All files target HTTPRoute resources with policy configurations

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
traffic-timeout.yaml Test fixture for request and idle timeout configuration
traffic-retries.yaml Test fixture for retry policy with backoff configuration
traffic-header-manipulation.yaml Test fixture for request/response header manipulation
traffic-cors.yaml Test fixture for CORS policy configuration
traffic-combined.yaml Test fixture demonstrating multiple traffic policies combined

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/kgateway/agentgatewaysyncer/testdata/inputs/traffic/traffic-timeout.yaml
@@ -0,0 +1,14 @@
apiVersion: gateway.kgateway.dev/v1alpha1
kind: AgentGatewayPolicy
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'AgentGatewayPolicy' to 'AgentgatewayPolicy'. The Kubernetes API type is defined as 'AgentgatewayPolicy' with a lowercase 'g' in 'gateway', as confirmed in api/v1alpha1/agentgateway_policy_types.go.

Suggested change
kind: AgentGatewayPolicy
kind: AgentgatewayPolicy

Copilot uses AI. Check for mistakes.
internal/kgateway/agentgatewaysyncer/testdata/inputs/traffic/traffic-retries.yaml
@@ -0,0 +1,21 @@
apiVersion: gateway.kgateway.dev/v1alpha1
kind: AgentGatewayPolicy
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'AgentGatewayPolicy' to 'AgentgatewayPolicy'. The Kubernetes API type is defined as 'AgentgatewayPolicy' with a lowercase 'g' in 'gateway', as confirmed in api/v1alpha1/agentgateway_policy_types.go.

Suggested change
kind: AgentGatewayPolicy
kind: AgentgatewayPolicy

Copilot uses AI. Check for mistakes.
internal/kgateway/agentgatewaysyncer/testdata/inputs/traffic/traffic-header-manipulation.yaml
@@ -0,0 +1,30 @@
apiVersion: gateway.kgateway.dev/v1alpha1
kind: AgentGatewayPolicy
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'AgentGatewayPolicy' to 'AgentgatewayPolicy'. The Kubernetes API type is defined as 'AgentgatewayPolicy' with a lowercase 'g' in 'gateway', as confirmed in api/v1alpha1/agentgateway_policy_types.go.

Suggested change
kind: AgentGatewayPolicy
kind: AgentgatewayPolicy

Copilot uses AI. Check for mistakes.
internal/kgateway/agentgatewaysyncer/testdata/inputs/traffic/traffic-cors.yaml
@@ -0,0 +1,27 @@
apiVersion: gateway.kgateway.dev/v1alpha1
kind: AgentGatewayPolicy
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'AgentGatewayPolicy' to 'AgentgatewayPolicy'. The Kubernetes API type is defined as 'AgentgatewayPolicy' with a lowercase 'g' in 'gateway', as confirmed in api/v1alpha1/agentgateway_policy_types.go.

Suggested change
kind: AgentGatewayPolicy
kind: AgentgatewayPolicy

Copilot uses AI. Check for mistakes.
internal/kgateway/agentgatewaysyncer/testdata/inputs/traffic/traffic-combined.yaml
@@ -0,0 +1,38 @@
apiVersion: gateway.kgateway.dev/v1alpha1
kind: AgentGatewayPolicy
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'AgentGatewayPolicy' to 'AgentgatewayPolicy'. The Kubernetes API type is defined as 'AgentgatewayPolicy' with a lowercase 'g' in 'gateway', as confirmed in api/v1alpha1/agentgateway_policy_types.go.

Suggested change
kind: AgentGatewayPolicy
kind: AgentgatewayPolicy

Copilot uses AI. Check for mistakes.
npolshakova
npolshakova requested changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the code of conduct on AI generated code https://github.com/kgateway-dev/community/blob/main/CODE-OF-CONDUCT.md It's totally okay to use AI to help you write code, but it's important to understand what the tests are actually checking for. In this case, the yaml configs are not quiet correct (AgentGatewayPolicy -> AgentgatewayPolicy), and there's no output files for the resulting xds, and the tests are not registered to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@npolshakova npolshakova npolshakova requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AgentgatewayPolicy: Add Traffic policy tests

2 participants

@adity1raut @npolshakova