api: Initial AgentgatewayParameters #13007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
gateway-bot
added
kind/feature
Contributor
|
I have some 'TODO' comments in #13018 that I'd like to iron out, but I enjoy this API so much that I have a first draft implementation. |
chandler-solo
added a commit
to chandler-solo/kgateway
that referenced
this pull request
Dec 4, 2025
@howardjohn wrote the API in kgateway-dev#13007 Signed-off-by: David L. Chandler <[email protected]>
Contributor
|
Let's close this out since #13018 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#13021
This is only adding the API. Implementation to follow.
The idea of the API is to primarily rely on 'overlays'. An overlay allows users to specify a
metadata/specfor objects, which is an opaque map of fields that is strategic-merge-patch applied over the generated objects. This exposes every field of the underlying APIs, without requiring us to expose each API individually with a slightly different API; users can just use the Kubernetes API's as they intended.In order to facilitate very common configuration, or configuration that benefits from being broken out. Currently, this includes
logLevel, labels/annotations (to apply to ALL objects),image, etc. We should avoid creeping this too much. Likely the following are potentially in scope (copied from AGW underlying config):|
config|||
config.enableIpv6|||
config.localXdsPath|Local XDS path. If not specified, the current configuration file will be used.||
config.caAddress|||
config.caAuthToken|||
config.xdsAddress|||
config.xdsAuthToken|||
config.namespace|||
config.gateway|||
config.trustDomain|||
config.serviceAccount|||
config.clusterId|||
config.network|||
config.adminAddr|Admin UI address in the format "ip:port"||
config.statsAddr|Stats/metrics server address in the format "ip:port"||
config.readinessAddr|Readiness probe server address in the format "ip:port"||
config.connectionTerminationDeadline|||
config.connectionMinTerminationDeadline|||
config.workerThreads|||
config.metrics|||
config.metrics.remove|||
config.metrics.fields|||
config.metrics.fields.add|||
config.hbone|||
config.hbone.windowSize|||
config.hbone.connectionWindowSize|||
config.hbone.frameSize|||
config.hbone.poolMaxStreamsPerConn|||
config.hbone.poolUnusedReleaseTimeout|We may also want a raw passthrough to AGW bootstrap config.
Change Type
/kind feature
Changelog
Additional Notes