Skip to content

Conversation

@EItanya
Copy link
Contributor

@EItanya EItanya commented Dec 2, 2025

Description

The goreleaser go tool dependency uses a library called lipgloss, which was using a missing tag:

go: github.com/charmbracelet/lipgloss/[email protected]: reading github.com/charmbracelet/lipgloss/go.mod at revision v2.0.0-beta1: unknown revision v2.0.0-beta1

This was fixed in the next major version,

Change Type

/kind cleanup

Changelog

NONE

Additional Notes

Copilot AI review requested due to automatic review settings December 2, 2025 21:50
@gateway-bot gateway-bot added do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. release-note-none labels Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a build issue caused by a missing tag in the lipgloss dependency (v2.0.0-beta1) used by goreleaser. The fix involves updating goreleaser from v2.11.2 to v2.12.7, which uses a valid version of lipgloss (v2.0.0-beta.3), and adding a replace directive to ensure the correct version is used.

Key changes:

  • Updated goreleaser/goreleaser/v2 from v2.11.2 to v2.12.7
  • Added a replace directive to override lipgloss/v2 from v2.0.0-beta1 to v2.0.0-beta.3
  • Multiple transitive dependency updates as a result of the goreleaser version bump

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updated goreleaser tool dependency from v2.11.2 to v2.12.7, added replace directive for lipgloss/v2 to use v2.0.0-beta.3, and updated numerous transitive dependencies
go.sum Updated checksums for all changed dependencies including goreleaser and its entire dependency tree

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

go.mod Outdated
software.sslmate.com/src/go-pkcs12 v0.5.0 // indirect
)

replace github.com/charmbracelet/lipgloss/v2 => github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.3
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replace directive at line 644 appears to be a self-referential replace that doesn't actually change the module path. A replace directive should typically point to a different module location or fork.

The current replace is:

replace github.com/charmbracelet/lipgloss/v2 => github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.3

This is only overriding the version, which is valid Go module syntax but unusual. However, since line 85 still shows v2.0.0-beta1 in the require block, this creates a confusing situation where the go.mod file shows one version but the actual resolved version (shown in go.sum) is different.

Consider updating line 85 to directly use v2.0.0-beta.3 and removing the replace directive, which would make the dependency graph clearer and avoid confusion.

Copilot uses AI. Check for mistakes.
go.mod Outdated
software.sslmate.com/src/go-pkcs12 v0.5.0 // indirect
)

replace github.com/charmbracelet/lipgloss/v2 => github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the goreleaser bump fixed this, do we still need this replace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently that was the only thing fixing it 😆, trying a newer version

@EItanya EItanya removed the do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. label Dec 2, 2025
@gateway-bot gateway-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 2, 2025
Copy link
Contributor

@jenshu jenshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to run make generate-all

Signed-off-by: Eitan Yarmush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants