-
Notifications
You must be signed in to change notification settings - Fork 616
tilt-improvements #13067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tilt-improvements #13067
Conversation
Signed-off-by: Guptak12 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the local Tilt development environment by aligning it with the production Dockerfile structure. It switches the development container base image from golang:latest to the Envoy base image, ensuring the Envoy binary is present for strict validation mode. The PR also introduces a dedicated tilt-values.yaml configuration file for local development settings.
Key Changes:
- Tiltfile now uses the Envoy base image (matching production) instead of golang:latest, with updated package installation and binary paths
- New tilt-values.yaml file configures strict validation mode, debug logging, and leader election settings for local development
- Simplified tilt-settings.yaml to reference the new tilt-values.yaml instead of test manifests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tilt-values.yaml | New configuration file with strict validation enabled, debug logging, and leader election settings for local Tilt development |
| tilt-settings.yaml | Updated to use the new tilt-values.yaml instead of common-recommendations.yaml from test manifests |
| Tiltfile | Updated Dockerfile to use Envoy base image, aligned binary path with production, and relaxed registry validation to support Kind clusters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Kush Gupta <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Kush Gupta <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Kush Gupta <[email protected]>
Description
Motivation: To improve the local development experience with Tilt by enabling ValidationMode=strict and fixing debugging issues. Currently, strict validation fails locally because the development container lacks the necessary Envoy binary, and debugging is hindered by leader election requirements in a single-replica setup.
What changed :
[Tiltfile]:
[tilt-values.yaml]:
Related issues:
Fixes #12956Change Type
/kind feature
/kind fix
Changelog
Additional Notes
This change aligns the local Tilt development environment with the production Dockerfile structure. This is critical for developers working on features that require ValidationMode=strict, as the validation logic expects the Envoy binary to be present in the container, which was missing in the previous golang:latest based image.
It also fixes a common friction point where debugging would fail due to leader election issues in single-replica local clusters.