-
Notifications
You must be signed in to change notification settings - Fork 616
Enhancing agw backend status support and testing #13073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d2c30a3 to
da1bc76
Compare
da1bc76 to
e611c05
Compare
3b7a6bb to
ade5b7e
Compare
7f61b3e to
71ad128
Compare
| port: 8888 | ||
| policies: | ||
| auth: | ||
| # TODO: kubebuilder:validate allows this but `translateBackendAuth` exepects "inline key or secretRef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to continue supporting passthrough here, so we may need to update translateBackendAuth to support it here:
| } else { |
pkg/kgateway/agentgatewaysyncer/backend/testdata/backend/ai-auth-secret-ref-not-found.yaml
Outdated
Show resolved
Hide resolved
pkg/kgateway/agentgatewaysyncer/backend/testdata/backend/ai-priority-groups-secret-ref.yaml
Show resolved
Hide resolved
npolshakova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple minor comments. Just something to watch out for- there might be some merge conflicts with #13089
Signed-off-by: Markus Kobler <[email protected]>
Signed-off-by: Markus Kobler <[email protected]>
Signed-off-by: Markus Kobler <[email protected]>
71ad128 to
04252d5
Compare
Signed-off-by: Markus Kobler <[email protected]>
Signed-off-by: Markus Kobler <[email protected]>
Description
Working on #11966 enhancing agw backend status support. Adds new tests following the new
GetTestResource/yamlpattern.Change Type
Changelog
Additional Notes
kubebuilder:validationerror?