Skip to content

Conversation

@markuskobler
Copy link
Contributor

@markuskobler markuskobler commented Dec 9, 2025

Description

Working on #11966 enhancing agw backend status support. Adds new tests following the new GetTestResource/yaml pattern.

Change Type

/kind fix

Changelog

Enhanced agentgateway backend error handling and status condition propagation.

Additional Notes

  • Should this be a kubebuilder:validation error?
  • Now that we added improved validation two agentgatewaysyncer backend inputs needed updating 1 & 2

@gateway-bot gateway-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note labels Dec 9, 2025
@markuskobler markuskobler force-pushed the agw-backend-status branch 4 times, most recently from d2c30a3 to da1bc76 Compare December 9, 2025 22:16
@markuskobler markuskobler marked this pull request as ready for review December 10, 2025 15:52
@markuskobler markuskobler changed the title WIP: Working on #11966 enhancing agw backend status support Enhancing agw backend status support and testing Dec 10, 2025
@gateway-bot gateway-bot added do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note labels Dec 10, 2025
@markuskobler markuskobler force-pushed the agw-backend-status branch 2 times, most recently from 3b7a6bb to ade5b7e Compare December 11, 2025 16:10
@gateway-bot gateway-bot added release-note and removed do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 11, 2025
@markuskobler markuskobler force-pushed the agw-backend-status branch 2 times, most recently from 7f61b3e to 71ad128 Compare December 11, 2025 18:55
port: 8888
policies:
auth:
# TODO: kubebuilder:validate allows this but `translateBackendAuth` exepects "inline key or secretRef"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to continue supporting passthrough here, so we may need to update translateBackendAuth to support it here:

Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple minor comments. Just something to watch out for- there might be some merge conflicts with #13089

@gateway-bot gateway-bot added do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. kind/fix Categorizes issue or PR as related to a bug. and removed do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants