Refactor and add tests for injections #13086
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Jumani <[email protected]>
gateway-bot
added
kind/cleanup
davidjumani
commented
Dec 10, 2025
| processGatewayCollectionOptions(&cfg) | ||
|
|
||
| assert.NotNil(t, cfg.listenerIndex) | ||
| assert.NotNil(t, cfg.transformationFunc) |
Contributor
Author
There was a problem hiding this comment.
AFAIK go can't test the equivalence of functions (test whether cfg.transformationFunc is the same as GatewayTransformationFunc, the default value), so the second best is to ensure it is not nil
Signed-off-by: David Jumani <[email protected]>
Signed-off-by: David Jumani <[email protected]>
davidjumani
changed the title
josh-pritchard
approved these changes
Dec 11, 2025
Contributor
josh-pritchard
left a comment
josh-pritchard
left a comment
There was a problem hiding this comment.
LGTM, thanks David
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup to #12999 (review) && #12926 (comment)
It refactors the injection code and adds tests
Change Type
Select one or more of the following by including the corresponding slash-command:
Changelog