Skip to content

fix: register go-test-coverage tool in tools/go.mod#14200

Open
Valyrian-Code wants to merge 5 commits into
kgateway-dev:mainfrom
Valyrian-Code:fix/register-go-test-coverage-tool
Open

fix: register go-test-coverage tool in tools/go.mod#14200
Valyrian-Code wants to merge 5 commits into
kgateway-dev:mainfrom
Valyrian-Code:fix/register-go-test-coverage-tool

Merge branch 'main' into fix/register-go-test-coverage-tool

438e397
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Jul 14, 2026 in 0s

Check failed

There is one commit incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 2536a2a fix: register go-test-coverage tool in tools/go.mo... Valid sign-off found
🟢 f28fd46 Merge branch 'main' into fix/register-go-test-cove... Skipped: sign-off not required in merge commit
🟢 330b178 Merge branch 'main' into fix/register-go-test-cove... Skipped: sign-off not required in merge commit
🔴 79850ce fix: tidy tools/go.sum for go-test-coverage tool c... Sign-off not found
🟢 438e397 Merge branch 'main' into fix/register-go-test-cove... Skipped: sign-off not required in merge commit

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~5 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin fix/register-go-test-coverage-tool