PT-FIXES: DOS-1370 generate deterministic model names to prevent conflicts in chained operations#4553
Merged
Nauna merged 2 commits intodevelopmentfrom Jan 20, 2026
Merged
Conversation
…s in chained operations
abdelaziz-mahdy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Saved flows with chained GroupBy operations fail to load after page reload because model names use random numbers (
GroupBy9591).Solution
Generate deterministic names based on source class, property, and sink type.
Before:
foam.tmp.GroupBy9591After:
foam.tmp.GroupBy_SourceClass_propertyName_SinkTypeBenefits
Files Changed
foam3/src/foam/mlang/sink/GroupBy.js- UpdatedgenModel()methodNote
Chained GroupBy operations were not functional before this fix. This change enables the feature for the first time.