fix: mark properties as transient in CapabilityWizardlet, QuickAgent, and BaseWizardlet#4629
fix: mark properties as transient in CapabilityWizardlet, QuickAgent, and BaseWizardlet#4629abdelaziz-mahdy wants to merge 1 commit intodevelopmentfrom
Conversation
… and BaseWizardlet
|
I think this will break some wizards, testing, please hold off on merging |
| { | ||
| name: 'wao', | ||
| hidden: true, | ||
| transient: true, |
There was a problem hiding this comment.
This can not be transient, it is expected that the server will send this to the client
There was a problem hiding this comment.
I think what this really needs is a proper parser to be set for java since wao is a js only concept. So all you should need is an UnknownFObjectParser. Same for the exceptionAgent
| { | ||
| class: 'foam.util.FObjectSpec', | ||
| name: 'exceptionAgent', | ||
| transient: true, |
There was a problem hiding this comment.
Also can't be transient, the idea is that this should be able to be set in a journal per capability, and while that doesn't happen now. I would like to retain the functionality
|
converted to draft to avoid merging by mistake. |
|
Wouldn't it be easier to just not output to JSON/J if the property doesn't have a dedicated class:? All of these properties don't specify class: so are just instances of foam.lang.Property so wouldn't appear on the server because they wouldn't have Java types. |
3 participants
fix json/j export on the client.
dont know if it breaks the normal flows though @jlhughes @noodlemoodle please check since I dont use them