feat: add confirmation prompts for deleting runtime journals and synchronous user confirmation function#4632
Conversation
…hronous user confirmation function
|
No, use -N |
| } | ||
| } | ||
|
|
||
| function confirmSync(message) { |
There was a problem hiding this comment.
How is this 'Sync' if it returns a Promise?
There was a problem hiding this comment.
#4634 removes it, since its not used anymore.
| }], | ||
|
|
||
| deleteRuntimeJournals: ['delete-runtime-journals', 'Delete runtime journals.', [], function() { | ||
| // Confirmation check to protect against accidental journal deletion |
There was a problem hiding this comment.
Wouldn't it be better to leave this task alone and either create a new one called 'safely-delete-runtime-journals' which ask for the confirmation or one called 'delete-runtime-journals-with-backup' which just moves the journals to something like journals.backup. instead. If anyone is scripting the build there would be nobody around to confirm.
There was a problem hiding this comment.
f6ec96e Joel added auto confirm. so its like force for scripting approaches.
3 participants
to avoid mistakenly deleting the journals on building with -j