Merged
Conversation
- as AlternateFlowWizardlet.init() could send a null delegate wao it
- currentData_ is only updated when controller mode changes
- due to default ttl find caching returning stale data
sarthak-marwaha
requested changes
Nov 26, 2025
src/foam/comics/v3/DetailView.js
Outdated
| .start(this.config.viewBorder) | ||
| .start(this.viewView, { | ||
| data$: self.currentData_$ | ||
| data$: self.data$ |
Collaborator
There was a problem hiding this comment.
This should be currentData, otherwise edit wont work properly
Collaborator
Author
There was a problem hiding this comment.
After publishing 'action' or 'finished' it will reload the data but not currentData_, the view will still see old data.
Collaborator
There was a problem hiding this comment.
Okay then the loadData that is called on sub of action or reload should then go and update currentData_. This has to use current data or edit will not work
Collaborator
There was a problem hiding this comment.
The loadLatch is only really used to set the currentData_ so you can move that logic into the loadData function it self
kgrgreer
reviewed
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.