Skip to content

Display form validation errors when hovering the create button#4720

Open
aiokaizen wants to merge 2 commits intodevelopmentfrom
feature/display-form-errors
Open

Display form validation errors when hovering the create button#4720
aiokaizen wants to merge 2 commits intodevelopmentfrom
feature/display-form-errors

Conversation

@aiokaizen
Copy link
Copy Markdown
Collaborator

Motivation

When the Create button is disabled, it's hard to know what the issue is exactly, especially when we have large forms with tabs (Take the User form for example). This PR makes it easy to know what are the validation errors I have simply by hovering on the Create button itself.

Screenshot

Validation Errors Screenshot

In this PR

  • Add tooltip when create button is disabled containing validation errors
  • Add toolTipFn property on Actions that allows tooltips to be calculated from when data changes
  • Implement support for html content on the tooltips.

+ Add `toolTipFn` property on Actions that allows tooltips to be calculated from a function
+ Implement support for html content on the tooltips.
@sarthak-marwaha
Copy link
Copy Markdown
Collaborator

Could you just make the tooltip property also accept a function, dont like the idea of having a separate property for this specific case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants