Deduplicate concurrent in-flight select() requests in TTLSelectCachingDAO#4928
Merged
kgrgreer merged 1 commit intokgrgreer:developmentfrom Mar 23, 2026
Conversation
d9394b3 to
22333ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TTLSelectCachingDAO only caches resolved results. When multiple concurrent callers issue identical
select()queries before the first one resolves, each caller fires a separate server request. In batch scenarios (e.g., 300 identical queries triggered simultaneously), this produces 300 redundant network round-trips.Solution
Store the in-flight promise in the cache immediately on miss. Concurrent callers with the same cache key receive the shared promise instead of starting new requests. When the promise resolves, replace it with the cloned result for subsequent cache hits. On error, remove the failed entry so the next caller retries.
Changes
this.cache[key]before it resolves, so concurrentselect_()calls with the same key share one request