Upstream: 2300bb45406a380924ba23feb59b2f21a9c80144#733
Merged
Conversation
…#17806) * Revert "Run JDK 21 workflows with latest JDK. (apache#17694)" This reverts commit 31ede5c * Review comments. * Review comments.
…rlier task is still publishing (apache#17509)" This reverts commit aca56d6.
…ache#17814) * fixes * fix cleanup
) When a nil clusterBy is used, we have no way of achieving a particular target size, so we need to fall back to a "mix" spec (unsorted single partition). This comes up for queries like "SELECT COUNT(*) FROM FOO LIMIT 1" when results use a target size, such as when we are inserting into another table or when we are writing to durable storage.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @MethodSource("data") | ||
| @ParameterizedTest(name = "{index}:with context {0}") | ||
| public void testInsertOnFoo1NoDimensionsWithLimit(String contextName, Map<String, Object> context) |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to remove the unused contextName parameter from the testInsertOnFoo1NoDimensionsWithLimit method. This involves:
- Removing the
contextNameparameter from the method signature. - Updating any method calls to
testInsertOnFoo1NoDimensionsWithLimitto no longer pass thecontextNameargument.
This change should be made in the extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java file.
Suggested changeset
1
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java
| @@ -1572,3 +1572,3 @@ | ||
| @ParameterizedTest(name = "{index}:with context {0}") | ||
| public void testInsertOnFoo1WithLimit(String contextName, Map<String, Object> context) | ||
| public void testInsertOnFoo1WithLimit(Map<String, Object> context) | ||
| { | ||
| @@ -1610,3 +1610,3 @@ | ||
| @ParameterizedTest(name = "{index}:with context {0}") | ||
| public void testInsertOnFoo1NoDimensionsWithLimit(String contextName, Map<String, Object> context) | ||
| public void testInsertOnFoo1NoDimensionsWithLimit(Map<String, Object> context) | ||
| { |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.