Upstream: 12a315edc194896617aafd50d8ea3c6674a89ea7#748
Conversation
* Update StringUtils.replace() after fix in JDK9 * Upgrade optimized string replace algorithm * Update methods by re-using declared StringUtils#replace method * Replace hard-coded UTF-8 encodings with StandardCharsets
…tionals; cleanup framework init (apache#17829) * cleans up `SqlTestFramework` initialization to leave the `OverrideModule` empty - so that tests could more easily take over parts * remove the `QueryComponentSupplier#createEngine` factory method - instead uses a `Class<SqlEngine>` and use the `injector` to initialize it * enables the usage of `!disabled <supplier> <message>` - to mark cases which are not yet supported with a specific configuration for some reason * fixes that `datasets` was not respecting the `rollup` specification of the ingest * enables to use `MultiComponentSupplier` backed tests - these will turn into matrix tests over multiple componentsuppliers - enabling running the same testcase in different scenarios
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| default Set<String> getTableNames() | ||
| default Set<String> getTableNames(BrokerSegmentMetadataCache segmentMetadataCache) |
Check notice
Code scanning / CodeQL
Useless parameter Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to remove the unused parameter segmentMetadataCache from the getTableNames method. This involves updating the method signature to exclude the parameter and ensuring that any calls to this method are also updated accordingly. Since we are only provided with the interface definition, we will update the method signature in the interface.
| @@ -62,3 +62,3 @@ | ||
|
|
||
| default Set<String> getTableNames(BrokerSegmentMetadataCache segmentMetadataCache) | ||
| default Set<String> getTableNames() | ||
| { |
| } | ||
|
|
||
| @SuppressWarnings("unused") | ||
| protected void validateFrameworkConfig(SqlTestFrameworkConfig cfg) |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we should remove the unused parameter cfg from the validateFrameworkConfig method. This will simplify the method's interface and eliminate the unnecessary parameter. The method will remain a no-op, as it currently does not perform any actions.
- Remove the
SqlTestFrameworkConfig cfgparameter from thevalidateFrameworkConfigmethod. - Update the method signature to reflect the removal of the parameter.
| @@ -208,3 +208,3 @@ | ||
| @SuppressWarnings("unused") | ||
| protected void validateFrameworkConfig(SqlTestFrameworkConfig cfg) | ||
| protected void validateFrameworkConfig() | ||
| { |
4 participants
No description provided.