Upstream: 295e7014fbd6e2b9b3d7075497daf95d6ca53e23#763
Merged
Conversation
* Introduce overlordNamespace label to filter out task pods from other namespaces * Fixing changed unit tests * Fix all unit tests in kubernetes overlord extension * Add table to specify new configs * Table with correct formatting * Documentation for allowing Druid to run overlord in seperate namespaces * Apply suggestions from code review Co-authored-by: Frank Chen <frankchen@apache.org> * Change Constant name to druid.overlord.namespace * Fix checkstyle * Documentation to clearer explain druid.indexer.runner.overlordNamespace * Only support deployment to other namespaces using Pod Template Adapter * Edit documentation to reflect only requiring using custom pod template adapter for deploying jobs in other namespaces * Remove unused imports --------- Co-authored-by: Frank Chen <frankchen@apache.org>
Co-authored-by: asishupadhyay <akulabs8@gmail.com>
* Improve S3 upload speeds using aws transfer manager * Pass correct amazonS3Client to ServerSideEncryptingAmazonS3 * Add Unit Test Cases * Turn on transfer manager by default * Add Druid documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private MockAmazonS3Client() | ||
| { | ||
| super(new AmazonS3Client(), new NoopServerSideEncryption()); | ||
| super(new AmazonS3Client(), new NoopServerSideEncryption(), new S3TransferConfig()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to replace the deprecated AmazonS3Client constructor with the recommended alternative. According to the AWS SDK documentation, the AmazonS3ClientBuilder should be used to create an instance of AmazonS3Client. This change will ensure that the code is using the latest and supported method for creating an AmazonS3Client instance.
- Replace the
new AmazonS3Client()call withAmazonS3ClientBuilder.standard().build(). - Ensure that the necessary import for
AmazonS3ClientBuilderis added.
Suggested changeset
1
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentMoverTest.java
| @@ -21,3 +21,3 @@ | ||
|
|
||
| import com.amazonaws.services.s3.AmazonS3Client; | ||
| import com.amazonaws.services.s3.AmazonS3ClientBuilder; | ||
| import com.amazonaws.services.s3.model.AccessControlList; | ||
| @@ -203,3 +203,3 @@ | ||
| { | ||
| super(new AmazonS3Client(), new NoopServerSideEncryption(), new S3TransferConfig()); | ||
| super(AmazonS3ClientBuilder.standard().build(), new NoopServerSideEncryption(), new S3TransferConfig()); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.