Skip to content

Squashed commit of the following:#795

Closed
kgyrtkirk wants to merge 1 commit intomasterfrom
add-qd-to-msqspec2
Closed

Squashed commit of the following:#795
kgyrtkirk wants to merge 1 commit intomasterfrom
add-qd-to-msqspec2

Conversation

@kgyrtkirk
Copy link
Copy Markdown
Owner

@kgyrtkirk kgyrtkirk commented Apr 7, 2025 •
edited
Loading

fdsfg

@kgyrtkirk
Squashed commit of the following:
fbbee95 
commit 61fc820
Merge: 16dcb26 e4bd0d2
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Apr 7 13:54:17 2025 +0000

    Merge remote-tracking branch 'apache/master' into add-qd-to-msqspec

commit 16dcb26
Merge: 53484f2 30b7bf0
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Apr 7 13:53:09 2025 +0000

    Merge commit '30b7bf0c9b17b1087c0ecbac85ecf5aeb3ae99dc' into add-qd-to-msqspec

commit 53484f2
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Apr 7 13:40:18 2025 +0000

    empty-commit

commit 19afc2d
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 18:57:40 2025 +0000

    fiximport

commit 46af7ac
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 18:26:08 2025 +0000

    import

commit 0e870ff
Merge: 6585062 6606d7c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 18:23:42 2025 +0000

    aa

commit 6606d7c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 18:22:52 2025 +0000

    remove-extract-fn

commit 6585062
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 16:01:01 2025 +0000

    remove

commit 1c270bb
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 15:58:52 2025 +0000

    remove comment

commit 0ba2e77
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 15:56:47 2025 +0000

    undo

commit 7b7581f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Apr 2 15:56:05 2025 +0000

    undo-a-lot

commit eb86c10
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 31 08:55:11 2025 +0000

    some

commit 6ac5841
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 28 15:18:29 2025 +0000

    a

commit 492ace2
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 15:44:22 2025 +0000

    renametest

commit 7b4c64f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 15:40:28 2025 +0000

    vc

commit cee3d27
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 15:12:09 2025 +0000

    x

commit 9adc8e5
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 15:08:43 2025 +0000

    x

commit 423a131
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 14:54:16 2025 +0000

    more

commit b71a00c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 14:42:02 2025 +0000

    x

commit 9d08fb6
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 14:37:18 2025 +0000

    add filter

commit 6972905
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 14:30:26 2025 +0000

    also work old

commit 20090be
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 14:27:46 2025 +0000

    make select dim1 work

commit d31eb85
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 13:44:05 2025 +0000

    add pctx

commit 47b58d4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 13:24:51 2025 +0000

    Revert "explore what plannerContext is used for"

    This reverts commit 92edf31.

commit 92edf31
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 13:24:49 2025 +0000

    explore what plannerContext is used for

commit 0805553
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 13:18:40 2025 +0000

    something

commit 585d86b
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 12:58:52 2025 +0000

    aa

commit 57db28e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 12:52:26 2025 +0000

    Revert "deadend - I guess"

    This reverts commit 75d3e12.

commit 75d3e12
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 12:52:22 2025 +0000

    deadend - I guess

commit 200cc3a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 27 12:52:09 2025 +0000

    test-change

commit 7e76556
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 19 06:57:26 2025 +0000

    fxx

commit 88e8e34
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 13:02:42 2025 +0000

    x

commit 330a17e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 12:52:33 2025 +0000

    x

commit 6df9e4c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 11:45:53 2025 +0000

    run select 1

commit ca0c034
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 10:58:11 2025 +0000

    updates

commit 376a7ad
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 08:08:59 2025 +0000

    Revert "quidem-ut-dart"

    This reverts commit e8e64fb.

commit e8e64fb
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 07:45:02 2025 +0000

    quidem-ut-dart

commit fc7d2f4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 18 07:44:22 2025 +0000

    yesterday

commit ed3cd4c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 14:56:00 2025 +0000

    mx

commit ef5406a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 13:14:21 2025 +0000

    Revert "x"

    This reverts commit fef959a.

commit fef959a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 13:14:19 2025 +0000

    x

commit 2bce986
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 12:30:31 2025 +0000

    cx1

commit 7478a57
Merge: 44a9aff 923c905
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 11:00:07 2025 +0000

    Merge branch 'dart-test-support' into decouple-msq-run-dmc

commit 923c905
Merge: 6faff99 08c9854
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 17 10:59:53 2025 +0000

    Merge remote-tracking branch 'apache/master' into dart-test-support

commit 44a9aff
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 14:58:36 2025 +0000

    rx

commit 5d4ad0e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 14:56:33 2025 +0000

    t

commit 8c218b8
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 14:52:05 2025 +0000

    emerging

commit ef8d291
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 12:51:47 2025 +0000

    fx

commit 312b5c1
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 11:46:16 2025 +0000

    cleanup-refactor

commit 5da22ef
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 14 11:42:21 2025 +0000

    more

commit 6faff99
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 14:50:17 2025 +0000

    cleanup

commit 90c4af5
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 14:43:18 2025 +0000

    s10x

commit 5e14914
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 12:46:21 2025 +0000

    qksqlengine

commit 94f5220
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 12:31:09 2025 +0000

    finish refactor

commit 4b1d6d1
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 12:22:09 2025 +0000

    remove_test-etc

commit 23c9947
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 10:11:29 2025 +0000

    fun

commit 38e11be
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 09:48:55 2025 +0000

    Reapply "changes - but are they needed?"

    This reverts commit 3cb857c.

commit 3cb857c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 09:48:07 2025 +0000

    Revert "changes - but are they needed?"

    This reverts commit 7881b57.

commit 7881b57
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 13 09:47:59 2025 +0000

    changes - but are they needed?

commit d4e95d9
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 17:08:12 2025 +0000

    mx

commit a63527e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 17:02:16 2025 +0000

    some unfinished

commit 84c2180
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:57:13 2025 +0000

    x

commit ccfec1b
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:49:01 2025 +0000

    somewhat hacky

commit da46a6f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:47:25 2025 +0000

    add queryDef field

commit 731591d
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:33:57 2025 +0000

    add queryDef field

commit 34a1a9e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:21:07 2025 +0000

    purge dartcontrollerfactory for now

commit a50c310
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:18:34 2025 +0000

    Revert "bit further down the road"

    This reverts commit 1798cd5.

commit 1798cd5
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 10:18:26 2025 +0000

    bit further down the road

commit bc4ba46
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 09:44:41 2025 +0000

    dont access implicit ctx

commit d624ddf
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 09:06:13 2025 +0000

    add getControllerContext

commit 9f81564
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 08:53:11 2025 +0000

    undo this

commit 60ad09c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 08:45:16 2025 +0000

    add

commit efa2ace
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 08:31:28 2025 +0000

    x

commit 6cdd7e9
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 12 07:57:12 2025 +0000

    cleanup

commit 54da6a3
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 16:36:27 2025 +0000

    Revert "was this a bug?"

    This reverts commit 99a3c1c.

commit 99a3c1c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 16:35:29 2025 +0000

    was this a bug?

commit f361a63
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 15:17:34 2025 +0000

    fix

commit a99c0b0
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 15:01:56 2025 +0000

    cleanup

commit 30926c8
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 14:53:10 2025 +0000

    fix a few testrs

commit 62beb93
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 11:21:05 2025 +0000

    Revert "flatten stuff"

    This reverts commit 5c11e24.

commit d52c862
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 11:03:51 2025 +0000

    Revert "@Assited try"

    This reverts commit ce9a76c.

commit ce9a76c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 11:03:49 2025 +0000

    @Assited try

commit 5c11e24
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 08:52:41 2025 +0000

    flatten stuff

commit 3b2809d
Merge: d63a5b8 26857dc
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 08:31:34 2025 +0000

    Merge branch 'dart-test-support' into decouple-msq-move-qk-execpoint

commit 26857dc
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 08:26:44 2025 +0000

    override

commit d63a5b8
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 11 08:23:28 2025 +0000

    +TEST:CalciteDartTest

commit 6a56486
Merge: 7cc9bab f27c023
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 15:07:46 2025 +0000

    Merge branch 'dart-test-support' into decouple-msq-move-qk-execpoint

commit f27c023
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 14:58:44 2025 +0000

    set host

commit e60eea5
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 14:43:08 2025 +0000

    Revert "fixes bug"

    This reverts commit a21433e.

commit a21433e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 14:43:06 2025 +0000

    fixes bug

commit af3beae
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 10:52:12 2025 +0000

    move doc

commit 07b986c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 10:43:57 2025 +0000

    fixes

commit 39c4f42
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 10:07:51 2025 +0000

    cleanup

commit 96fa16a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 09:48:22 2025 +0000

    remove

commit 0230874
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 10 09:47:59 2025 +0000

    cleanup tests/etc

commit 07eb975
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:52:28 2025 +0000

    cleanup

commit 0d8089d
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:40:22 2025 +0000

    moretest

commit ae737be
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:38:30 2025 +0000

    make quidem run

commit 808a4c8
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:32:43 2025 +0000

    cleanup/etc

commit 73872ba
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:14:11 2025 +0000

    halfway

commit a569e95
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:08:42 2025 +0000

    cleanup

commit 5115dd7
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 12:04:52 2025 +0000

    fixme

commit 5e51e1a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 11:53:27 2025 +0000

    Revert "crap"

    This reverts commit 9a9eef4.

commit 9a9eef4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 11:53:25 2025 +0000

    crap

commit 83e36a3
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Mar 7 08:17:18 2025 +0000

    middle

commit 11b212a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:29:19 2025 +0000

    retain running dart with msqtestsqlmodule for now

commit cff97bf
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:28:45 2025 +0000

    add-trial

commit 96b2a9c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:19:53 2025 +0000

    run dart w/o old msqtestmodule

commit e1c4693
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:13:27 2025 +0000

    cleanup/etc

commit 637ae37
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:12:47 2025 +0000

    same

commit 008a155
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:11:33 2025 +0000

    u

commit 810d306
Merge: 35d2294 fe641fd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 14:05:45 2025 +0000

    Merge branch 'msq-small-test-enhancements' into make-msq-tests-really-run-the-task

commit 35d2294
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 12:15:43 2025 +0000

    update expecttions

commit 7cec2d2
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 12:08:26 2025 +0000

    t

commit 8f053d1
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 10:15:29 2025 +0000

    some changes which have broke it

commit d788f9f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 10:11:20 2025 +0000

    unlucky-for-some

commit 0a1059e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 10:00:43 2025 +0000

    messedup?

commit 823d01c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 09:46:55 2025 +0000

    x

commit b574226
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 08:36:26 2025 +0000

    refact

commit 1d806d6
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Mar 6 08:21:44 2025 +0000

    crap

commit fb4ec06
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 16:08:36 2025 +0000

    sx

commit 061a741
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 13:57:58 2025 +0000

    up

commit 4e2fd3c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 13:56:33 2025 +0000

    m

commit 9b85514
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 13:53:48 2025 +0000

    aa

commit d60fab3
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 11:00:36 2025 +0000

    stuff

commit fe641fd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Wed Mar 5 07:46:24 2025 +0000

    make TestTimelineServerView

commit c0ed1b4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 15:10:36 2025 +0000

    use TimelineServerView instead BrokerServerView

commit 5de20dc
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 13:04:31 2025 +0000

    s

commit 99ccba0
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 12:44:12 2025 +0000

    rename/etc

commit 0543df6
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 11:40:45 2025 +0000

    my-wood

commit c899e7a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 08:24:06 2025 +0000

    move stuff

commit 5aa1836
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Mar 4 08:22:07 2025 +0000

    a

commit 064e362
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 3 14:59:36 2025 +0000

    fixes

commit 71e14d9
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Mar 3 07:39:40 2025 +0000

    some-leftover

commit abe6916
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 28 10:20:57 2025 +0000

    use interface

commit 747034b
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 28 10:04:56 2025 +0000

    bootstrap

commit 7cc9bab
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 27 17:45:05 2025 +0000

    some updates

commit c807855
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 16:41:17 2025 +0000

    extracted

commit e4a343b
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 14:13:45 2025 +0000

    add interface

commit c7f001c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 14:08:05 2025 +0000

    dont break a lot of tests

commit 3e602fe
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 09:34:10 2025 +0000

    Revert "unrelated review"

    This reverts commit a855804.

commit a855804
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 09:34:08 2025 +0000

    unrelated review

commit eabf689
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Tue Feb 25 08:29:49 2025 +0000

    use msqspec0

commit 706df05
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 15:00:53 2025 +0000

    msqspec0

commit 06e04dd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 13:25:42 2025 +0000

    dust

commit 3a49d56
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 13:22:47 2025 +0000

    oneless

commit b4a1857
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 13:16:47 2025 +0000

    add annotations+test to querycontext

commit 23bd6d4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 13:10:52 2025 +0000

    qctx

commit 1b82517
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:55:05 2025 +0000

    s

commit 684149c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:53:13 2025 +0000

    leave note

commit 264237f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:51:02 2025 +0000

    in the midle

commit 3b672e6
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:30:43 2025 +0000

    u

commit 01a7017
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:20:36 2025 +0000

    Revert "undo this for now"

    This reverts commit 2676cd3.

commit 5186877
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 12:03:33 2025 +0000

    x

commit 4d82cc0
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 11:43:26 2025 +0000

    move compactionmetricspec

commit 68a7dae
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 11:08:09 2025 +0000

    ugly-fix

commit ca7acc7
Merge: 2676cd3 e70bd76
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Mon Feb 24 10:51:10 2025 +0000

    Merge remote-tracking branch 'apache/master' into decouple-msq

commit 2676cd3
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 16:42:07 2025 +0000

    undo this for now

commit ceab58e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 16:39:04 2025 +0000

    remove context field

commit 36a9763
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 16:38:31 2025 +0000

    move check outside of planner

commit 8d6819a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 16:35:31 2025 +0000

    refactor a bit

commit 372831e
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 16:29:30 2025 +0000

    some

commit 5972d21
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:48:21 2025 +0000

    update

commit 66dffc8
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:38:24 2025 +0000

    cleanup

commit 9ff20bd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:35:30 2025 +0000

    cleanup

commit 1420ab4
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:29:00 2025 +0000

    move method

commit 431d816
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:24:31 2025 +0000

    cleanup

commit e1094a2
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:19:58 2025 +0000

    remove msqctrltask2

commit 9f6db02
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:15:41 2025 +0000

    empty-commit

commit e809243
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:13:22 2025 +0000

    clean up getContext stuff

commit 95d37ed
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:03:06 2025 +0000

    undo DruidQuery2

commit ed40cec
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:00:53 2025 +0000

    cleanup

commit 5a9d32b
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 14:00:32 2025 +0000

    cleanup

commit ff17f84
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:59:35 2025 +0000

    cleanup

commit c35c705
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:58:36 2025 +0000

    refactor

commit eeae304
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:55:56 2025 +0000

    up

commit 820894f
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:43:03 2025 +0000

    up

commit 4364600
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:41:05 2025 +0000

    more

commit 5941ab6
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:36:58 2025 +0000

    fn1

commit 2480860
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:30:32 2025 +0000

    up

commit 47d6a2c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:27:21 2025 +0000

    more

commit e0ee7e5
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:17:18 2025 +0000

    up

commit 07a10cd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 13:13:55 2025 +0000

    up

commit 4540da2
Merge: 2a3dc86 9df9223
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 12:31:33 2025 +0000

    Merge remote-tracking branch 'apache/master' into decouple-msq

commit 2a3dc86
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Fri Feb 21 12:31:25 2025 +0000

    more

commit 91f10a0
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 15:39:05 2025 +0000

    up

commit 90cf8dd
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 15:37:47 2025 +0000

    aa

commit 3bc083a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 15:09:32 2025 +0000

    up

commit d7c754a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 15:04:34 2025 +0000

    up

commit 8d19317
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 14:20:19 2025 +0000

    stuff

commit ba15a8c
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 14:06:02 2025 +0000

    looks okayish

commit 9c3429a
Author: Zoltan Haindrich <kirk@rxd.hu>
Date:   Thu Feb 20 13:54:19 2025 +0000

    add stuff
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 7, 2025
View reviewed changes
Comment thread extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQSpec.java

@JsonProperty("columnMappings")
public ColumnMappings getColumnMappings()
public String getId()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
MSQSpec0.getId
Loading
; it is advisable to add an Override annotation.
Comment thread ...ery/src/main/java/org/apache/druid/msq/indexing/destination/MSQTerminalStageSpecFactory.java Dismissed
Comment thread extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java
replaceTimeChunks,
null,
projectionSpecs,
terminalStageSpecFactory.createTerminalStageSpec(

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
terminalStageSpecFactory
Loading
may be null at this access because of
this
Loading
null argument.

Copilot Autofix

AI about 1 year ago

To fix the problem, we need to ensure that terminalStageSpecFactory is not null before it is dereferenced. This can be done by adding a null check before the dereference. If terminalStageSpecFactory is found to be null, we should handle this case appropriately, possibly by throwing an exception or providing a default value.

Suggested changeset 1
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java
--- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java
+++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java
@@ -308,5 +308,5 @@
           projectionSpecs,
-          terminalStageSpecFactory.createTerminalStageSpec(
+          (terminalStageSpecFactory != null ? terminalStageSpecFactory.createTerminalStageSpec(
               plannerContext
-          )
+          ) : null)
       );
EOF
@@ -308,5 +308,5 @@
projectionSpecs,
terminalStageSpecFactory.createTerminalStageSpec(
(terminalStageSpecFactory != null ? terminalStageSpecFactory.createTerminalStageSpec(
plannerContext
)
) : null)
);
Copilot is powered by AI and may make mistakes. Always verify output.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2025

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 6, 2025

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area - Batch Ingestion Area - MSQ Area - Querying stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kgyrtkirk @github-advanced-security