Flakeparts rewrite#215
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the Nix module namespace by replacing all dynamic ${namespace} references with the fixed khanelinix identifier and cleans up related imports and option definitions.
- Replaces
config.${namespace}andoptions.${namespace}withconfig.khanelinixandoptions.khanelinixacross all modules - Removes the
namespaceargument from module parameter lists - Updates custom import functions (e.g.,
lib.snowfall.fs.get-file→lib.getFile) and streamlines module imports
Reviewed Changes
Copilot reviewed 287 out of 418 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/home/services/jankyborders/default.nix | Fixed namespace references and removed dynamic calls |
| modules/nixos/programs/nix/default.nix | Updated namespace, added self/inputs, refactored imports |
| modules/home/default.nix | Added recursive imports for home modules |
| modules/nixos/default.nix | Added recursive imports for NixOS modules |
| modules/nixos/programs/graphical/file-managers/nautilus/default.nix | Replaced ${namespace} with khanelinix |
Comments suppressed due to low confidence (1)
modules/home/services/jankyborders/default.nix:15
- The call to
lib.khanelinix.mkBoolOptis incorrect. You should inheritmkBoolOptfromlib.khanelinixand call it directly (e.g.,enable = mkBoolOpt false "...";) rather thanlib.khanelinix.mkBoolOpt.
enable = lib.khanelinix.mkBoolOpt false "Whether to enable jankyborders in the desktop environment.";
3019e87 to
138b243
Compare
Been using flake parts more and more for different projects. Wanted to have the granular control instead of offloading the core functionality of my flake. While being able to plug and play different modules, when needed.
Not sure why... but the imported shared module isn't behaving properly. Just duplicating logic, for now.
28f7e15 to
98f4636
Compare
Remove unnecessary files that were only for recursive imports.
Use common nomenclature to align better with other code bases
98f4636 to
eca604f
Compare
Current 50.0 and 50.1 crash on start...
Use the in flake formatter
40b7ea0 to
826d4d4
Compare
Right now we eval each other configuration to generate a ssh config. We will just maintain the host information manually to avoid the eval cost.
incorrect hash
84d6e24 to
b80bee9
Compare
Try to make sure we are using the right package set for darwin/home manager
b80bee9 to
68b0d0e
Compare
36d50cc to
54bc176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.