Skip to content

Flakeparts rewrite#215

Merged
khaneliman merged 25 commits into
mainfrom
flakeparts-rewrite
Jul 22, 2025
Merged

Flakeparts rewrite#215
khaneliman merged 25 commits into
mainfrom
flakeparts-rewrite

Conversation

@khaneliman

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the Nix module namespace by replacing all dynamic ${namespace} references with the fixed khanelinix identifier and cleans up related imports and option definitions.

  • Replaces config.${namespace} and options.${namespace} with config.khanelinix and options.khanelinix across all modules
  • Removes the namespace argument from module parameter lists
  • Updates custom import functions (e.g., lib.snowfall.fs.get-filelib.getFile) and streamlines module imports

Reviewed Changes

Copilot reviewed 287 out of 418 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/home/services/jankyborders/default.nix Fixed namespace references and removed dynamic calls
modules/nixos/programs/nix/default.nix Updated namespace, added self/inputs, refactored imports
modules/home/default.nix Added recursive imports for home modules
modules/nixos/default.nix Added recursive imports for NixOS modules
modules/nixos/programs/graphical/file-managers/nautilus/default.nix Replaced ${namespace} with khanelinix
Comments suppressed due to low confidence (1)

modules/home/services/jankyborders/default.nix:15

  • The call to lib.khanelinix.mkBoolOpt is incorrect. You should inherit mkBoolOpt from lib.khanelinix and call it directly (e.g., enable = mkBoolOpt false "...";) rather than lib.khanelinix.mkBoolOpt.
    enable = lib.khanelinix.mkBoolOpt false "Whether to enable jankyborders in the desktop environment.";

@khaneliman khaneliman force-pushed the flakeparts-rewrite branch 12 times, most recently from 3019e87 to 138b243 Compare July 21, 2025 18:04
Been using flake parts more and more for different projects. Wanted to
have the granular control instead of offloading the core functionality
of my flake. While being able to plug and play different modules, when
needed.
Not sure why... but the imported shared module isn't behaving properly.
Just duplicating logic, for now.
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch from 28f7e15 to 98f4636 Compare July 21, 2025 20:36
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch from 98f4636 to eca604f Compare July 21, 2025 20:40
Current 50.0 and 50.1 crash on start...
Use the in flake formatter
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch from 40b7ea0 to 826d4d4 Compare July 22, 2025 02:22
Right now we eval each other configuration to generate a ssh config. We
will just maintain the host information manually to avoid the eval cost.
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch 3 times, most recently from 84d6e24 to b80bee9 Compare July 22, 2025 04:01
Try to make sure we are using the right package set for darwin/home
manager
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch from b80bee9 to 68b0d0e Compare July 22, 2025 04:10
@khaneliman khaneliman force-pushed the flakeparts-rewrite branch from 36d50cc to 54bc176 Compare July 22, 2025 04:35
@khaneliman khaneliman merged commit 54bc176 into main Jul 22, 2025
16 checks passed
@khaneliman khaneliman deleted the flakeparts-rewrite branch July 22, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants