fix: avoid blocking the event loop during OAuth token exchange#1342
Open
kratos0718 wants to merge 1 commit into
Open
fix: avoid blocking the event loop during OAuth token exchange#1342kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
The Google OAuth callback handler (async auth route) exchanges the code for a token with a synchronous requests.post(). A blocking call inside an async handler freezes the entire event loop for the network round-trip, so every other in-flight request stalls during each login. Offload it with asyncio.to_thread so the loop stays responsive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Google OAuth callback (
src/khoj/routers/auth.py, the asyncauthroute) exchanges the authorization code for a token using a synchronousrequests.post:A blocking call inside an
asynchandler blocks the entire event loop for the duration of the network round-trip. So during every login's token exchange, all other in-flight requests the server is handling are frozen.Fix
Offload the blocking call to a worker thread with
asyncio.to_thread, keeping the loop responsive:asynciois already imported in this module; no new dependency, behavior unchanged.python -m py_compileclean.