.aidigestminify#35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the minify feature in v1.5.0, allowing files to be included with placeholder content instead of full content through .aidigestminify patterns. The feature includes CLI support, library API options, and watch mode compatibility.
- Adds
.aidigestminifyfile support for including files with placeholder descriptions - Implements
--minify-fileCLI option and library callback customization - Refactors codebase to separate concerns with new
types.tsanddigest.tsfiles
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils.ts | Removes Ignore type import and adds new utility functions moved from index.ts |
| src/types.ts | New file defining TypeScript types for IgnoreInstance, MinifyFileDescriptionCallback, and ProcessedFile |
| src/index.ts | Major refactor moving core functionality to digest.ts, keeping only CLI and public API |
| src/index.test.ts | Adds comprehensive tests for minify functionality and updates existing tests for code style |
| src/digest.ts | New file containing core processing logic moved from index.ts with minify support |
| package.json | Version bump to 1.5.0 and adds ESLint/Husky development dependencies |
| eslint.config.js | New ESLint configuration with TypeScript support |
| README.md | Extensive documentation updates for minify functionality and library usage |
| CLAUDE.md | Updates development guidance with minify feature details |
| CHANGELOG.md | Documents v1.5.0 changes |
| .husky/pre-commit | Adds pre-commit hook for lint-staged |
| .github/workflows/test.yml | Adds linting step to CI workflow |
| .aidigestignore | Excludes scripts directory from codebase dumps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+881
to
+882
| minifyFile: string = ".aidigestminify", | ||
| ): Promise<void> { |
There was a problem hiding this comment.
The default parameter should be defined in the function signature's options parameter with other defaults, not as a separate parameter with a default value. This creates inconsistency with other optional parameters.
Suggested change
| minifyFile: string = ".aidigestminify", | |
| ): Promise<void> { | |
| minifyFile: string, | |
| ): Promise<void> { | |
| if (minifyFile === undefined) { | |
| minifyFile = ".aidigestminify"; | |
| } |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.