Add MaxConnectionLifetime to Go GLV (3.7 WebSocket driver)#10
Open
jayanthKiddom wants to merge 1 commit into3.7-devfrom
Open
Add MaxConnectionLifetime to Go GLV (3.7 WebSocket driver)#10jayanthKiddom wants to merge 1 commit into3.7-devfrom
jayanthKiddom wants to merge 1 commit into3.7-devfrom
Conversation
Adds a MaxConnectionLifetime setting to ClientSettings and DriverRemoteConnectionSettings. When set, the loadBalancingPool checks connection age on each write: expired idle connections are closed immediately; expired connections with in-flight requests are drained (kept alive but not selected for new work) and a replacement is created as capacity allows. Disabled by default (0). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxConnectionLifetime time.DurationtoClientSettingsandDriverRemoteConnectionSettingsloadBalancingPool.getLeastUsedConnection()checks connection age on each write: expired idle connections are closed immediately; expired connections with in-flight requests are drained (kept alive but not selected for new work) and a new connection is created as capacity allows0= connections live forever), so there is no behavior change for existing usersCreatedAtfield added toconnectionstruct;isExpired()helper method addedTest plan
TestConnectionIsExpired— verifiesisExpired()returns false when disabled (0), false within lifetime, true after lifetimeTestExpiredIdleConnectionClosed— expired + idle connection is closed and removed from poolTestExpiredBusyConnectionKeptButNotSelected— expired + busy connection is retained but a fresh connection is selected insteadTestMaxConnectionLifetimeClientSettingsWiring— field onClientSettingsflows intoloadBalancingPoolTestMaxConnectionLifetimeDefaultIsZero— default value is 0 (disabled)TestMaxConnectionLifetimeDriverRemoteConnectionSettingsWiring— field onDriverRemoteConnectionSettingsflows intoloadBalancingPool0for the newmaxConnLifetimeparameter🤖 Generated with Claude Code