Skip to content

Kieker 1978 spring boot example#597

Open
DaGeRe wants to merge 20 commits intomainfrom
KIEKER-1978-SpringBoot
Open

Kieker 1978 spring boot example#597
DaGeRe wants to merge 20 commits intomainfrom
KIEKER-1978-SpringBoot

Conversation

@DaGeRe
Copy link
Contributor

@DaGeRe DaGeRe commented Jul 29, 2024

Pull Request

Contribution

This pull request provides the following contribution to Kieker

  • Contribution 1 Add spring boot example (that behaves somehow different than the regular spring examples, since the spring-instrument javaagent needs to be added and the load time weaving needs to be added to the spring boot configuration) This only works if logback is directly added to the agent (as it has been configured before splitting the monitoring agent into multiple modules)

Code Quality Thresholds

  • It was necessary to raise any code quality thresholds
  • If yes, which had to be raised and why was it necessary?
    ..

@DaGeRe DaGeRe requested a review from shinhyungyang July 29, 2024 15:02
@DaGeRe DaGeRe force-pushed the KIEKER-1978-SpringBoot branch 2 times, most recently from 028e9b9 to a799bf5 Compare July 30, 2024 07:14
@DaGeRe DaGeRe force-pushed the KIEKER-1978-SpringBoot branch from 30bb310 to 98b4a49 Compare August 1, 2024 12:38
@shinhyungyang
Copy link
Contributor

I will see if I can do something for the Kieker image.

@shinhyungyang
Copy link
Contributor

I will see if I can do something for the Kieker image.

:)

https://github.com/rju/kieker-build

@shinhyungyang
Copy link
Contributor

I will see if I can do something for the Kieker image.

:)

https://github.com/rju/kieker-build

@rju @DaGeRe Maybe we can migrate the repository under kieker-monitoring at some point?

@DaGeRe
Copy link
Contributor Author

DaGeRe commented Aug 2, 2024

Thanks, having the repo in the kieker-monitoring organization is not an issue: https://github.com/kieker-monitoring/kieker-build Adding probably also isn't, but we'll have to deploy to dockerhub. I'll have a look at this, but probably we'll need @rju for this.

@DaGeRe
Copy link
Contributor Author

DaGeRe commented Aug 2, 2024

I just added curl to the used packages: kieker-monitoring/kieker-build@f78f36f And afterwards, I installed it via

docker login --username=kiekerci
docker build -t "kieker/kieker-build:openjdk11" .
docker push kieker/kieker-build:openjdk11

This seems to be successful: https://hub.docker.com/layers/kieker/kieker-build/openjdk11/images/sha256-2ab6f08966f789e7e439b178d8801787f07480d69f4bef15b86a0f6013f79af2?context=explore

So I restarted the Jenkins job, and lets see what happens.

In general, we should also update the README of dockerhub: https://hub.docker.com/r/kieker/kieker-build (since our images are not based on Ubuntu 18.04) and update to the eclipse temurin distribution (since the openjdk images are deprecated), but thats an issue for another day.

@DaGeRe DaGeRe mentioned this pull request Sep 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants