Skip to content

Support for Apache Skywalking#24

Merged
DaGeRe merged 3 commits intokieker-monitoring:mainfrom
Marcel-Ha:support-skywalking
Feb 28, 2025
Merged

Support for Apache Skywalking#24
DaGeRe merged 3 commits intokieker-monitoring:mainfrom
Marcel-Ha:support-skywalking

Conversation

@Marcel-Ha
Copy link
Contributor

Add basic support for apache skywalking framework.

Draft, as I want to test first if the pipeline runs. Also it needs to be checked if different configurations are possible.

@Marcel-Ha Marcel-Ha marked this pull request as ready for review February 20, 2025 16:00
@Marcel-Ha
Copy link
Contributor Author

@DaGeRe You can have a look at it now. In addition to the standard configuration I also added a configuration with sampling (was not sure about a good sampling rate though, used 60 per 3 seconds). I think that was the only reasonable configuration option to also include from the possible configuration options but maybe you want to take a look there as well.

@DaGeRe
Copy link
Collaborator

DaGeRe commented Feb 25, 2025

Thanks for the PR, looks fine.

It would be nice to have a configuration that disables parts of the process, to get an estimate whether the overhead is caused by the instrumentation, the data collection or writing the data. Would it be possible to have another customize_enhance.xml, which only monitors the constructor, or a method that is not existing? This might yield to instrumentation etc. being started, but no overhead from the real data collection.

@Marcel-Ha
Copy link
Contributor Author

I added a new configuration which uses the constructor for the customize_enhance.xml. In my limited tests the performance was very similar to the default moobench, so I am not sure if it actually has some overhead or if the differences were just random.

@DaGeRe
Copy link
Collaborator

DaGeRe commented Feb 28, 2025

Thanks for the update, let's give it a try in the measurement environment. We can always remove a configuration later.

@DaGeRe DaGeRe merged commit 29dff10 into kieker-monitoring:main Feb 28, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants